Fix renderer discoverer implicit name
See mfkl/libvlcsharp-samples#10 (closed) and mfkl/libvlcsharp-samples@dce768ca and 10d1c416
Compilation directives aren't enough for shared code running in netstandard 2.0 and netstandard 2.0 has no way to distinguish between iOS and Android.
I'm not a fan of hard coding libVLC.RendererList.Last().Name but it works (for now) and the user always has the other constructor in case they want to specify the service discovery protocol themselves.
Note: mdns should not be returned by libvlc on Apple platforms, as it does not work.
Added documentation as well (more cherry picks incoming).
Merge request reports
Activity
43 /// <summary> 44 /// Create a new renderer discoverer with a LibVLC and protocol name depending on host platform 45 /// </summary> 46 /// <param name="libVLC">libvlc instance this will be connected to</param> 47 /// <param name="name">The service discovery protocol name depending on platform. Use LibVLC.RendererList to find the one for your platform</param> 48 public RendererDiscoverer(LibVLC libVLC, string name) 41 49 : base(() => Native.LibVLCRendererDiscovererNew(libVLC.NativeReference, name), Native.LibVLCRendererDiscovererRelease) 42 50 { 43 51 } 44 52 53 /// <summary> 54 /// Create a new renderer discoverer with a LibVLC. The protocol name is inferred (last item of LibVLC.RendererList) 55 /// </summary> 56 /// <param name="libVLC">libvlc instance this will be connected to</param> 57 public RendererDiscoverer(LibVLC libVLC) 58 : base(() => Native.LibVLCRendererDiscovererNew(libVLC.NativeReference, libVLC.RendererList.Last().Name ?? string.Empty), Native.LibVLCRendererDiscovererRelease) -
Did you mean
.LastOrDefault()?I'd prefer to call
this(libVLC, libVLC.RendererList.LastOrDefault().Name ?? string.Empty)instead, to avoid duplication.Why is it important to have a "default" value for the name. Can't the user choose by himself? Taking the last item seems "random" to me...
Why is it important to have a "default" value for the name. Can't the user choose by himself?
No. The user may have no clue what the bonjour protocol is or that mdns does not work on Apple platforms. Needing to know about this stuff can be avoided and it should be IMO.
Taking the last item seems "random" to me...
It's not, though I get why it seems that way but I don't have a better solution. Last item is either mdns (all platforms except Apple, also the only item for now) or bonjour (Apple only platforms, first one is mdns and it's not working on Apple platforms).
Edited by Martin Finkel-
If the first value is not a sane option, then it is a bug in libvlc and either that option will work in the future, or will be disabled.
How can you assert then that the last value will always be something usable on all platforms in the future versions?
I'm not really fond of making such decisions for the user if there's nothing saying "the default value is the last in the list". Either that decision belongs to libvlc or to the user.
What does libvlcpp do for that call? do they provide a default value?
changed this line in version 2 of the diff
added 1 commit
- 4cca07a1 - RendererDiscoverer: Fix service discovery name inference