Skip to content
Snippets Groups Projects
  1. Nov 14, 2024
  2. Nov 13, 2024
  3. Nov 02, 2024
    • Sergio Ammirata's avatar
      Fix criteria for classifying rtp vs rtcp packets. · 128403eb
      Sergio Ammirata authored
      We were using payload_type < 200 and now we use a range outside 200 to 205 for the classification.
      When the marker bit of the rtp header is turned on, the payload type of the rtp packet could match the range we were looking for, thus incorrectly classifying rtp data as rtcp data. For example, STMPE-2110 uses rtp payload types 96 through 127 (224 to 255 with the marker bit on).
      With this fix, librist will also classify rtp packets with a payload type of 72-77 as rtcp. Since that range is reserved for “RTCP conflict avoidance” on the RFC4855 standard, we can leverage that to add a feature to the library (keep reading).
      Lastly, let it be documented that the library WILL only classify rtp packets as rtcp if they live in the range 200-205 or 72-77. Everything else is considered rtp data.
      If anyone wants to use custom rtcp packets not defined in the RIST specification and they want their implementation to work with librist, they must use the 72-76 range or they will be treated as rtp data and run the risk of corrupting their data stream.
      128403eb
  4. Oct 26, 2024
  5. Oct 25, 2024
  6. Aug 16, 2024
  7. Jun 16, 2024
Loading