- Sep 12, 2022
-
-
The substream handling was under a lot of precondition, leading to a lot of indentation. Moving this handling into a separate function allows early return within the function, which reduce to a single indentation level and greatly simplify the reading of the function while simplifying the caller site where it was only a specific case to handle.
-
vlc_fifo_t are coming with their own lock which is exposed on the public interface, so provide sanitization state check functions like those available for vlc_mutex_t.
-
The test is reliably failing with thread sanitizer enabled, without the previous patches: ================== WARNING: ThreadSanitizer: data race (pid=242170) Write of size 8 at 0x7b6c00010088 by thread T10: #0 DecoderPlayCc ../../src/input/decoder.c:1008 (libvlccore.so.9+0xebbf5) #1 ModuleThread_QueueCc ../../src/input/decoder.c:1064 (libvlccore.so.9+0xec031) #2 decoder_QueueCc ../../include/vlc_codec.h:444 (test_src_input_decoder+0x5768) #3 decoder_decode_check_cc ../../test/src/input/decoder/input_decoder_scenarios.c:79 (test_src_input_decoder+0x5a4e) #4 DecoderDecode ../../test/src/input/decoder/input_decoder.c:90 (test_src_input_decoder+0x3dd4) #5 DecoderThread_DecodeBlock ../../src/input/decoder.c:1376 (libvlccore.so.9+0xed9f1) #6 DecoderThread_ProcessInput ../../src/input/decoder.c:1498 (libvlccore.so.9+0xee14a) #7 DecoderThread ../../src/input/decoder.c:1786 (libvlccore.so.9+0xef877) Previous read of size 1 at 0x7b6c00010088 by thread T8: #0 vlc_input_decoder_HasCCChanFlag ../../src/input/decoder.c:2445 (libvlccore.so.9+0xf2a2b) #1 vlc_input_decoder_SetCcState ../../src/input/decoder.c:2464 (libvlccore.so.9+0xf2b5f) #2 EsOutSelectEs ../../src/input/es_out.c:2446 (libvlccore.so.9+0x1095c4) #3 EsOutSelect ../../src/input/es_out.c:2686 (libvlccore.so.9+0x10a7fc) #4 EsOutVaControlLocked ../../src/input/es_out.c:3270 (libvlccore.so.9+0x10dea5) #5 EsOutControlLocked ../../src/input/es_out.c:3147 (libvlccore.so.9+0x10d0ae) #6 EsOutVaPrivControlLocked ../../src/input/es_out.c:3759 (libvlccore.so.9+0x112282) #7 EsOutPrivControl ../../src/input/es_out.c:4028 (libvlccore.so.9+0x11505c) #8 es_out_vaPrivControl ../../src/input/es_out.h:105 (libvlccore.so.9+0x125a49) #9 es_out_PrivControl ../../src/input/es_out.h:112 (libvlccore.so.9+0x125b38) #10 es_out_SetEs ../../src/input/es_out.h:124 (libvlccore.so.9+0x125c4b) #11 Control ../../src/input/input.c:2123 (libvlccore.so.9+0x130e15) #12 MainLoop ../../src/input/input.c:724 (libvlccore.so.9+0x129676) #13 Run ../../src/input/input.c:428 (libvlccore.so.9+0x127faa) -
vlc_input_decoder_HasCCChanFlag also needs to be protected, and the owner->lock mutex will be removed in later patches, to be completely replaced by the already existing fifo lock. The new cc.lock allows better thread safety without risking a deadlock between the super-decoder and the sub-decoder, by protecting the very state being synced by both of them.
-
Sub-decoders are decoders whose state is defined by previous decoders. Specifically in the current case, picture frames with specific SEI data can convey subtitles as closed captions and report them from the decoder implementation itself. Since the core never locks the implementation, and the implementation can be asynchronously reporting subtitles, a common lock need to be setup so that the core can then check and use the sub-decoders being created without racing against the upper decoder implementation. Co-authored-by:François Cartegnie <fcvlcdev@free.fr>
-
Separate the early return to make it clear that what follows require a valid closed-caption decoder. Then, use vlc_input_decoder_Flush directly, because pf_flush must be called from the CC decoder thread, and the fifo must be flushed beforehand, instead of calling it directly.
-
The test provides an infrastructure based on previous transcode tests and video output tests, that will serve as basis for other input_decoder.c tests.
-
-eq is for comparing integers and prints errors like: install_wrapper.sh: 27: [: Illegal number: imageformats
-
- Sep 10, 2022
-
-
So the order of build is always respected, even in case of build error.
-
-
Just like we do with autotools builds, we configure the target every time we build a contrib. In the case of cmake, touching `toolchain.cmake` does rebuild the cmake contribs but if there's a cache it's not reconfigured and doesn't rebuild anything.
-
-
This is how it's done for autotools target and some cmake targets. It makes long lines a little better to read.
-
It contains Marvin's patch to respect BUILD_SHARED_LIBS.
-
We do force CMAKE_INSTALL_LIBDIR which makes srt not use any other of the GNU directories... Merged upstream: https://github.com/Haivision/srt/pull/2450
-
It can be removed once we update to the next release. The previous patch potentially hides an error handling.
-
-
-
lrint uses libm which is set in CMAKE_REQUIRED_LIBRARIES. But check_function_exists() won't use it with cmake older than 3.12. This removes the need for Wno-dev.
-
It has the same effect as using HOSTVARS_PIC which we already use.
-
-
The test was always true.
-
The test was always true. Move the dependencies definitions higher in the makefile, in line with other contribs.
-
It's automatically enabled for Windows targets and not used otherwise.
-
It's automatically enabled for Apple targets and not used otherwise.
-
These options don't exist. The others are set to non default values.
-
It's used to set the library prefix between glew (dynamic) and glew_s (static). But only the static target (glew_s) is selected in our environment. It will pick the proper prefix on its own. It's not even a public option to set.
-
FLUIDSYNTH_NOT_A_DLL is not used anymore when built statically. Here's the file used to generate the public header: https://github.com/FluidSynth/fluidsynth/blob/v2.1.8/include/fluidsynth.cmake
-
It's off by default.
-
They are already using $(PIC) with $(HOSTVARS_PIC)
-
LDFLAGS is already set in HOSTVARS
-
I believe that's what the + is for. It's used on all other $(CMAKEBUILD) calls.
-
No need to change the current directory.
-
- Sep 09, 2022
-
-
The plugins are now correctly installed to the correct location.
-
So that we can factor together the different checks on X11 and Wayland support.
-
-
We need the plugins for the Qt Wayland integration. Co-authored-by:Alexandre Janniaux <ajanni@videolabs.io>
-
This is required when building for linux, and might cause a system provided version to be used, causing conflicts during linking. Typically, the error message at link time will look like this: /usr/bin/ld: .libs/libqt_plugin.so: version node not found for symbol qt_version_tag@Qt_5.10 Co-authored-by: -
-
-
