if the `asprintf()` fails then the pointer is left in an undefined state.

should it fail and the append-to-list and any subsequent loops have managed
to make it through the low-memory condition successfully, then firstly some
code was inevitably going to read the pointer in trying to use the string,
and secondly at some point later when the list of seekpoints is destroyed,
`vlc_seekpoint_Delete()` would be calling `free()` on it.

the original version of this patch simply reset the pointer to null upon
failure - if anything is not designed to cope with a null name then that's
an entirely separate existing bug. however, two other places within this
file that make seekpoints, including the very similar `LoadChapterGpac()`
function, take the action of destroying seekpoints for which they have
failed to allocate the name, and feedback from review requested that same
behaviour here.

should `asprintf()` fail, leaving the pointer in an undefined state, we
must ensure the null entry is written over it, rather than in the next
entry, else the calling code when looping over the list will read it.

`p_sys->psz_base_url` is `free()`'d by `Close()` as used in the error path.

use of a temporary variable, as requested in review, fixes the problem.

Cherry-picked from 28bb0054.

Cherry-picked from cf16bd05.

Cherry-picked from a08a437d.

Cherry-picked from 1fc8b688.

Cherry-picked from 187d2118.

David authored 3 years ago and Hugo Beauzée-Luyssen committed 3 years ago

Signal that the compatibility mode is not needed and VLC takes
care about the safe area directly.

David authored 3 years ago and Hugo Beauzée-Luyssen committed 3 years ago

New M1 Macs contain a notch, covering part of the screen. Analog to
the Quicktime player, when implementing VLCs internal fullscreen,
the video is scaled inside the safe area of the notch only, leaving
the top area black.

Fixes #26291

The current code base won't compile with 5.0.3 or less.

The current code base won't compile with 5.0.3 or less.

This is a partial revert of 785c6dfe. Some servers (notably PLEX, UMS,
and some TV sets) amend the exposed media type with additional subtypes
for further differentiation not relevant to VLC, so it is actually
correct to compare the beginning of the string only.

For instance "object.container" can turn into
"object.container.storageFolder" or "object.container.person.musicArtist"
so the plain strcmp will fail to recognize the container nature.

Fixes vlc-ios#1239

(cherry picked from commit 741f1f90)

Maxime Chapelet authored 3 years ago and Jean-Baptiste Kempf committed 3 years ago

the display can be created when the application state is active or inactive
inactive state actually happens when the application comes back from background and becomes active just after a very short amount of time
hence we should allow vout initialization only when application state is not background

(cherry picked from commit 012b57cd)

Maxime Chapelet authored 3 years ago and Jean-Baptiste Kempf committed 3 years ago

(cherry picked from commit f702e742)

Maxime Chapelet authored 3 years ago and Jean-Baptiste Kempf committed 3 years ago

(cherry picked from commit 19fc95b3)

David authored 3 years ago and David committed 3 years ago

vlc-osx is used to generate the final VLC executable, and therefore
the RPATH to the Frameworks directory is needed as well, in order
to find the Sparkle framework.

Followup fix for !1155.

François Cartegnie authored 3 years ago and Hugo Beauzée-Luyssen committed 3 years ago

refs #26427

(cherry picked from commit c8d319ed)

Marvin Scholz authored 3 years ago and Felix Paul Kühne committed 3 years ago

Changing the install name is no longer necessary since
0831e42e
and doing so breaks the ad-hoc code signing leading to a broken
bundle and pseudo-bundle on arm64 which requires ad-hoc signing.

Fix #26127

Marvin Scholz authored 3 years ago and Felix Paul Kühne committed 3 years ago

The Frameworks folder was missing in the rpath, leading to Frameworks
like Sparkle requiring change of the install_name after it was built
instead of just using rpath properly.

Felix Paul Kühne authored 3 years ago and Hugo Beauzée-Luyssen committed 3 years ago

This correctly deploys custom values set through mobile apps

(cherry picked from commit c9b80802)

Alexandre Janniaux authored 4 years ago and François Cartegnie committed 3 years ago

(cherry picked from commit 551734e0)

Alexandre Janniaux authored 4 years ago and François Cartegnie committed 3 years ago

We don't use cancellation in this code.

(cherry picked from commit b7f6deba)

(cherry picked from commit 305c390d)

(cherry picked from commit 0d61e9a1)

prioritize manifests over data chunks

(cherry picked from commit 7b4eff1c)

(cherry picked from commit 3e32bbeb)

(cherry picked from commit b85ef41f)

(cherry picked from commit cdd1dda3)

(cherry picked from commit 33fb9022)

(cherry picked from commit f36a0c55)

(cherry picked from commit af72f0bb)

now checked in parsers

(cherry picked from commit 76fd9ead)

(cherry picked from commit a0115366)

(cherry picked from commit 451f6242)