We are no longer on Freenode for a while now.

Diogo Simao Marques authored 1 month ago and Felix Paul Kühne committed 1 month ago

The default criteria's localized label is updated to "Custom" to match
its purpose.

Diogo Simao Marques authored 1 month ago and Felix Paul Kühne committed 1 month ago

The indicator is removed because the default criteria is not related to any
ascending or descending order.

The default criteria is only based on the user's interaction.

Diogo Simao Marques authored 1 month ago and Felix Paul Kühne committed 1 month ago

The feature allowing the user to change the order of a playlist's media
is now restricted to only the default sorting criteria.

This avoids any issue related to the loss of a the custom order when a
sorting criteria other than default was selected during the changes.

Diogo Simao Marques authored 1 month ago and Felix Paul Kühne committed 1 month ago

The default sorting criteria is now explicitly added to the list.

Diogo Simao Marques authored 1 month ago and Felix Paul Kühne committed 1 month ago

Different sorting criteria can be applied to the array of media stored
in a playlist.

Closes #729

Diogo Simao Marques authored 1 month ago and Felix Paul Kühne committed 1 month ago

The VLCMediaLibraryKit version has been updated to be able to use
the latest changes.

Diogo Simao Marques authored 1 month ago and Felix Paul Kühne committed 1 month ago

The sorting criteria are now displayed in the menu generated for the
playlists' content.

This removes the hack in the options' action sheet that was displaying
the same icon for the bookmarks and chapter.

Since we do have a proper icon for the chapters, it is no longer needed.

Closes #1757

The icon dedicated to the bookmarks now has a name accordingly and
a new icon has been added for the chapters.

Yonat Sharon authored 2 years ago and Felix Paul Kühne committed 1 month ago

- on lockscreen and when using external controls (like headphones and car controls). (resolve #428 #800)

Signed-off-by: Felix Paul Kühne <felix@feepk.net>

Diogo Simao Marques authored 2 years ago and Felix Paul Kühne committed 2 months ago

If the current playing media has been recognized as a live stream
and it turns out to have a positive value length, the player in the
control center is updated to the default player.

The playback is not interrupted anymore at the end of the media and
the play/pause and previous/next interactions do not lead to the end
of the playback either.

Closes #1416

Regression from optimization in 4f8560b0

Diogo Simao Marques authored 2 months ago and Felix Paul Kühne committed 2 months ago

The user interface style is now properly set on iOS as it used to
be and still supports the visionOS windows.

This fixes a visual glitch previously introduced with the support
of the visionOS compilation.

Improve Observable by adding a function that calls out to each observer and handles the case of disappearing observers

Diogo Simao Marques authored 4 months ago and Felix Paul Kühne committed 2 months ago

The coding style has been reviewed in several files and some chunks
of code have been simplified.

Mohamed Sliem authored 8 months ago and Felix Paul Kühne committed 2 months ago

This should hide the angled arrow in playlist cell for only last played
one. This makes the indicator more cleaner and clearer.

Mohamed Sliem authored 10 months ago and Felix Paul Kühne committed 2 months ago

MediaCategoryViewController: Save currently playing playlist

capture the current playing playlist with cell didSelect action and
presist the data in user defaults.

MediaCatogoryViewController: Save last played playlist through Gestures

Capture the last played playlist which is selected through long  press
gestures with  actions of play, append to queue and play next in
queue when the queue is empty.

Extensions: Added UserDefaults extension for custom types

Added two function for decoding and encoding custom types and save it to
user defaults

MediaLibrary Models: Added last played Playlist model

Helper model to presist last played  playlist necessary data in user
defaults

MediaCategoryViewController: Save last played playlist function

Updated function to be able to cache custom type using UserDefaults

Extensions: fixed UserDefaults function naming

rename function name and parameters to fix the issue of recursive call
of UserDefaults super set function

VLCPlaybackService: Added will stop observer

Addded observer when playback will stop. for catching last played media
and notify view to reload data for updating the last
played playlist label

MediaCollectionViewCell:Added Last Played Indicator Label

Take advantage of newLabel and use it in playlist cells to show an
indicator of the last played playlist. Set a condition for only showing
the label during only the active playback

VLCPlaybackService: Added New Playabck Observer

Added new playback observer name  for Playback Will Stop State in the header
file

MediaCollectionViewCell: Fixed Showing LastPlayed Label

Fixed showing last played label when the playback is active and in some
cases of playlist in player queue

MediaCategoryViewController: Fixed Removing Observer Bug

Handling adding and removing observer in all cases like long tap menu
actions, and playing a single playlist media when the player is activily
playing a queue. Handling reloading data in all playing cases

Localization: Added Last played playlist label title

Added English localization for last played label and set it in
MediaCollectionViewCell class

MovieCollectionViewCell: Adapt last played playlist indicator

MediaCategoryViewController: Fixed Minor coding style violation

removed Debugging Print statements, and fixed else if style

LastPlayedPlaylistModel: Added Last Played Media Model

Added LastPlayedPlaylistMedia to indicate the last played media in a
given playlist.

MediaCategoryViewController: Saving last played media addition

Refactored saveCurrentPlaylistInfo and added lastPlayedPlaylistMedia
model to it. This will presist the last played media in playlist and
updated funcion calls arguments

Added LastPlaylistPlayedMedia Key

VLCPlaybackService: Update PlaybackWillStop Observer user info

get the current playing media before the playback stops and fetch this
media in VLCMLMedia type. Attached this media to PlaybackWillStop
userInfo

MediaCategoryViewController: Captured last played media

Using the userInfo posted by PlaybackWillStop observer. presisted the
media data and its given playlist to indicate the UI to show last played
one

MediaCategoryViewController: Check the last played media in a given
playlist

Check for the view model if it the last played playlist. depending on
the check result, checking for the last played media in this given
playlist to show it as lastPlayedMedia

MediaCateogoryViewController: Added isLastMedia to check condition

MediaCollectionViewCell: Last played indicator for VLCMLMedia

Added functionality to show last played label in the last played media
when playback is stopped

MovieCollectionViewCell: Last played label

Added last played label to GroupView to indicate last played playlist in
Grid mode

MediaCollectionViewCell: Fixed CheckImageView on selection bug

Removed unnecessary statement of hiding CheckImageView in setting last
played label function

MediaCollectionViewCell: Updated Last played indicator logic

Added the logic to show last played indicator for audio media types

MediaCollectionViewCell: Fixed coding style

MovieCollectionViewCell: Fixed Coding Style

VLCPlaybackService: Limited PlaybackWillStop Observation

Limited Posting a notification for PlaybackWillStop observers to only
iOS OS

MediaCategoryViewController: Limited Lastplayed media observation

Limited Observing on PlaybackWillStop Observer to iOS only. also limited
last played playlist indication helper functions

LastPlayedPlaylistModel: Removed unnecessary initializer

Removed Initializer and set model properties to non optional value.
Moved them to PlaylistModel file

MediaCategoryViewController: LastPlayedPlaylistModel nil-safety

Added optional binding to function that uses LastPlayedPlaylist Model

MediaCategoryViewController: Refactored checking last played playlist cell

Refactored the code responsible for checking last played playlist and
last played media in a given playlist. removed duplicates.

MediaCategoryViewController: Removed unneeded OS checking

MediaCollectionViewCell: Handled updating newLabel

This should fix showing  of last played text in the newlabel for the New
Media

MediaCategoryViewController: Refactored observing last played playlist
logic

Removed Static variable and added observer to handle caching only
playlist model to indicate the last played one.

VLCConstants: Added CurrentPlaylistQueueIds Key

PlaylistModel: Added CurrentPlaylistQueueInfo model

This helper model is used in currentPlaylistMediasQueue dictionary which
helps to indicate the last played media correctly for Queue playing
options.

MediaCategoryViewController: Ability to indicate last played media from
the queue

This should solve the issue of the last played media indication for a given
playlist when the queue has different medias from different playlists with the Using of mediaId, playlistId and playlistTitle.

MediaCategoryViewController: Refactor Handling Player Queue Playlist

This should refactor the method used in catching the last playlist from
the queue when it contains multiple playlists. Solved some code style
comments.Removed using json encoding and decoding with user defaults.

MediaCategoryViewController: Refactor Handling Player Queue Playlist

This should refactor the method used in catching the last playlist from
the queue when it contains multiple playlists. Solved some code style
comments.Removed using json encoding and decoding with user defaults.

MediaCategoryCollectionCells: Refactored Hiding the last played label

This should change the cases of hiding and showing last played label.
hiding the label when currently playling collection is a playlist,
otherwise it will be shown.

PlaylistModel: Refactored LastPlayedPlaylistModel to adapt NSCoding

This should enable the encoding and decoding using NSKeyedUnarchiver and NSKeyedarchiver to store it in userDefaults.

PlaybackCacheHelper: Cache the current queue medias playlists

This should cache the media's playlist info played with actions
[playNextInQueue, appendToQueue].It is a helper for catching the last
played playlist in a queue with more than one playlist or a different
medias from different playlists.

MediaCategoryViewController: Changed collectionSelectedIndex variable type

This should change the type of the collectionSelectedIndex to optional IndexPath for more memory saftey

MediaCollectionViewCell: Refactored Last Played functionality

This should refactor the functionality of handling the last played
label.

MediaCategoryViewController: Save last played when app is terminated

This should add the ability to update the last played value from any
viewed model.The last logic only updates the value if the view model is
a playlist or a playlist media collection. Removed the dependancy on
optional values in last played helper methods.