Some issue has come up, this should also handle audio playback speed,
and for this we would need to also fix audio playback speed restoration.
Seeing this, maybe KEY_CURRENT_X constants should be used, and not the
RESUME_VIDEO_X from Settings.kt. This would mean remaking the first
commit of the merge request ...

That would also help with KEY_CURRENT_MEDIA_RESUME being used in both
audio and video ...

Fixes #3153

Fixes #3148

Fixes #3149

Fixes #3150

Fixes #3151

Nicolas Pomepuy authored 2 months ago and Duncan McNamara committed 2 months ago

This has multiple side effects:
- Saving the speed is now synchronous in the dialog / Auto controls
- Restoring the speed is now factorised in the PlaylistManager
- Shared preferences simplification
- Better UX for the user

Before that we used the audio only query that filtered out the items that
only contains streams. This commit changes the query to all and then filter
all the playlist containing only video media

Duncan McNamara authored 2 months ago and Nicolas Pomepuy committed 2 months ago

The Medialibrary sometimes doesn't have the media's length,
and won't know that the file has ended.

For some files this causes a finished video to keep it's time and when
played again starts at the end, and leave the player.

This forces the ML to mark the file as finished and reset it's time

Duncan McNamara authored 2 months ago and Nicolas Pomepuy committed 2 months ago

Instead of re-adding the default internal storage as an ML root, save
previous roots, reset the db, and re-add these roots.

This is !2080 but for TV as I forgot to also apply the changes to the tv
settings

Duncan McNamara authored 2 months ago and Nicolas Pomepuy committed 2 months ago

Some filenames from opensubtitles.org had characters not authorized for an
Android Uri. This sanitizes the filename so it can be used as dest in copyFile
Cf https://www.rfc-editor.org/rfc/rfc2396 #2.4.3 mentionned in the Uri.parse
method doc

Duncan McNamara authored 2 months ago and Nicolas Pomepuy committed 2 months ago

If for some reason the FileUtils.copyFile fails, the subtitleItem should
be removed from the ExternalSubDirectory's downloading items to change
the item's state back to NotDownloaded to stop the download progress
animation. Also nice to display a snackbar error for the user.