- Oct 17, 2022
-
-
This will prevent using the bundled "harfbuzz-ng" which is really harfbuzz 1.7.4. The bundled "harfbuzz", which a very old version, is still compiled and linked in however, and can't be disabled [1]. [1]. https://bugreports.qt.io/browse/QTBUG-104647
-
-
Recently, the contrib libjpeg was changed to libjpeg-turbo with some improvements over libjpeg [1]. While Qt also bundles libjpeg-turbo, it is better to only build one copy. [1]. 4a1bd36f
-
In practice, Qt was already using the system png by accident, because the png is almost always built and installed before Qt is configured.
-
Steve Lhomme authored
* gcc is upgraded to 11.3.0 for vlc-debian-win32. * vlc-debian-win64 (win64 with gcc) is left out for now as it fails to compile gcrypt with a compiler bug/error. ``` during RTL pass: pro_and_epilogue ../../cipher/poly1305.c: In function 'poly1305_init': ../../cipher/poly1305.c:380:1: internal compiler error: in choose_baseaddr, at config/i386/i386.c:6915 380 | } | ^ 0x1539b77 internal_error(char const*, ...) ???:0 0x616601 fancy_abort(char const*, int, char const*) ???:0 0xe279f8 ix86_expand_prologue() ???:0 0x11ab44b gen_prologue() ???:0 0x89e851 thread_prologue_and_epilogue_insns() ???:0 Please submit a full bug report, with preprocessed source if appropriate. Please include the complete backtrace with any bug report. See <https://gcc.gnu.org/bugs/> for instructions. ```
-
- Oct 16, 2022
-
-
Fixes CVE-2022-37434.
-
In this commit, the --with-sanitizer option is forwarded to the configure script for VLC, but also intercepted so that the emcc call creating the plugin list can use the option as well. It's necessary for now since the plugin list is not generated by automake yet, thus the call to emcc is not intercepted to add the sanitizer options added from VLC's configure.ac.
-
- Oct 15, 2022
-
-
Since we no longer rely on embedding hard-coded arrays into the shader, we can finally free up this size limitation, thus improving the quality of dithering massively.
-
This commit merely activates the functionality supported by the previous commits, tying it all together.
-
This change will allow us to integrate more advanced libplacebo features, such as those requiring LUT-based tone-mapping (in recent versions of libplacebo).
-
This creates a pl_gpu suitable for use by shaders. It's worth noting that this commit does not hook the resulting pl_gpu into the shaders yet, because doing so would break the resulting shaders until we add support for mapping descriptors (in the following commit).
-
Simply continuing in this error case without assigning the corresponding uniform will silently lead to a broken shader / image. Since we rely on these assumptions, we should assert them so any such bugs are actually found in a debuggable way. This is only a theoretical risk since, as the comment points out, we don't rely on any such variables. But maybe this will unexpectedly change in the future.
-
This code, as written, is technically undefined behavior. It was fine so far because we didn't end up using the shader objects in any way that wasn't baked into the resulting pl_shader_res, but it needs to be fixed to allow shaders to reference GPU resources which may be used later on.
-
The dithering code can end up using uniform array variables when plugging pl_gpu information into the shader, so pre-emptively add support for these.
-
We have this for glUniform4fv, add the other types so I can use them.
-
This code as-written leaks libplacebo-related objects in the event of a failure here.
-
I want to start using the pl_opengl integration, so we need to slightly revise the check to ensure we also have the libplaceo opengl header available. It's worth pointing out that these headers eventually become non-conditional (in libplacebo git master as of writing), but we need to live with this transitional logic until then.
-
It should come from the environment to select what preferred set of Windows API is selected. And there's no reason to force it just for mingw.
-
Otherwise our CXXFLAGS/LDFLAGS are not used See https://doc.qt.io/qt-6/qmake-environment-reference.html#cache-file
-
-
Steve Lhomme authored
In the contribs we * check that HOST-protoc has the same version as protobuf otherwise * check that protoc has the same version as protobuf AC_CHECK_TOOL() only tests one version of protoc for the protobuf matching.
-
Steve Lhomme authored
protoc 3.4.1 reports a libprotoc version of 3.4.0
-
- Oct 14, 2022
-
-
-
https://developer.android.com/ndk/guides/audio/aaudio/aaudio AAudio is a native PCM-only audio API starting Android 8.0 (but enabled in VLC starting Android 9.0 due to some bugs). Having tested it with few device. The latency reported by this new API is correct and without any irregularity, contrary to the AudioTrack.getTimeStamp() API that is very broken. Plus side, a huge gain of performance due to the absence of JNI C->JAVA->C++. -40ms of latency reported by Sync-One2 versus -150ms with AudioTrack. The remaining 40ms of latency to fix are likely on the mediacodec/vout side.
-
-
-
aout_stream_TimingReport() is the way to go.
-
-
-
-
-
-
Like mmdevice with wasapi/directsound. To get support for multiple audio tracks playback at once, all aout modules need to be split between device and stream. This is the first step in that direction (second step is to add aout_stream_t in the CORE). This will allow a single aout module to choose between audiotrack, opensles and the future aaudio plugin depending on the audio format/codec. Indeed, only AudioTrack can handle pass-through, and PCM playback should be done by aaudio in priority.
-
Adding forward declarations for Start and Stop temporarily.
-
-
- Oct 13, 2022
-
-
Steve Lhomme authored
-
Steve Lhomme authored
Enabled blake2 and chacha20 because there are some missing ifdef throughout the code to enable/disable some code if they are not set. The easiest fix is to just enable them, rather than patching the code.
-
This was attempted in 4f72f199, but back then, qtsvg still needed the Qt vendored zlib. Now, this has been fixed and we don't need the vendored zlib. zlib from the contribs has a few fixes [1] over the Qt version, so it is prefered. Just like the explicit -qt-zlib, we specify -system-zlib so we don't rely on the automatic fallback to the vendored version. Since this fails at configure time, it has been helpful when hacking away at the compiler flags and options. 1. https://github.com/madler/zlib/blob/master/ChangeLog
-
QMAKE_LDFLAGS does not exist [1]. The contrib libdir needs to be added to the linker flags in order to link to system libraries (e.g. zlib) during conftest. 1. https://doc.qt.io/qt-5/qmake-variable-reference.html#qmake-lflags
-
Steve Lhomme authored
Requires a Docker image with this patch [1] to build [1] videolan/docker-images!196
-