Skip to content
Snippets Groups Projects

Fix typos with codespell tool

Merged Ziemowit Zabawa requested to merge ziemek99/x264:codespell into master
All threads resolved!

This includes fixing convert_method_to_flag so it recognizes gauss parameter properly instead of silently defaulting to bicubic. Previously the only way to use Gaussian resizing method was to call the function incorrectly, with misspelled guass parameter.

The proccess was manually supervised, so there's no need to worry that meaningful code has been corrupted. (Disclaimer: there still might be some other typos or linguistic mistakes not detected by codespell, so watch out.)

Edited by Ziemowit Zabawa

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • added 1 commit

    • cf25cec6 - Fix typos with codespell tool

    Compare with previous version

  • Ziemowit Zabawa
  • Ziemowit Zabawa
  • Author Contributor

    If you decide to apply any of those suggested changes, please squash and fast-forward merge if it's possible. I'd like to retain the original commit message, please (just like I'd do with fixup in interactive rebase in pure Git).

    Edited by Ziemowit Zabawa
  • Hi. It looks good but imho we shouldn't change:

    • extras/*
    • tools/gas-preprocessor.pl

    tools/gas-preprocessor.pl should be fixed in upstream (dunno if this is real upstream repo) : https://github.com/libav/gas-preprocessor.git

    Also I am not sure about "laid out" in common\x86\trellis-x64.asm (as I understand the comment is about memory layout of structure). May be whole sentence should be rephrased.

  • added 1 commit

    • d59ea387 - Fix typos with codespell tool

    Compare with previous version

  • added 1 commit

    • 1920066d - Fix typos with codespell tool

    Compare with previous version

  • Anton Mitrofanov resolved all threads

    resolved all threads

  • Anton Mitrofanov approved this merge request

    approved this merge request

  • Anton Mitrofanov added 3 commits

    added 3 commits

    Compare with previous version

  • Anton Mitrofanov enabled an automatic merge when the pipeline for d8debbc6 succeeds

    enabled an automatic merge when the pipeline for d8debbc6 succeeds

  • Please register or sign in to reply
    Loading