Brad Smith authored 4 years ago and Anton Mitrofanov committed 3 years ago

On modern versions of OpenBSD, the number of processors online may differ from
the number of processors configured.

Use 'cmhs' (which does an unsigned greater or equal comparison)
instead of 'cmhi' (which does an unsigned greater comparison).

This makes sure that dct coeffs with a magnitude of 1 are recognized
in the output nnz buffer.

Henrik Gramner authored 4 years ago and Henrik Gramner committed 4 years ago

Large stack allocations on Windows need to use stack probing in order
to guarantee that all stack memory is committed before accessing it.
This is done by ensuring that the guard page(s) at the end of the
currently committed pages are touched prior to any pages beyond that.

Anton Mitrofanov authored 4 years ago and Anton Mitrofanov committed 4 years ago

Bug report by Zhengzhi Duan.

Make pointers to padded buffers aligned both before and after padding.

In 10-bit mode pixel_asd8 expects 16-byte alignment for pix1 and pix2.

It's not required, and BSD doesn't support it.

Anton Mitrofanov authored 4 years ago and Anton Mitrofanov committed 4 years ago

Broke after unifying of 8-bit and 10-bit libraries.

Anton Mitrofanov authored 4 years ago and Anton Mitrofanov committed 4 years ago

This bug never occurs with the current reference management logic.
Bug report by Lingjiang Fang.

Anton Mitrofanov authored 4 years ago and Anton Mitrofanov committed 4 years ago

This bug mainly occurred when encoding with high bitrate (low QP).
It did not occur when encoding in baseline or main profile.

It became unused in cde9a933.

0.5% - 2% overall speedup on
`./x264 --threads X --profile high --preset veryfast --crf 15 -o /dev/null park_joy_420_720p50.y4m`
cabac is responsible for roughly 1/6 of the CPU use.
Branch mispredictions are reduced by 15% to 20%.

cortex-s53: 0.5% faster
cortex-a72: 2%  faster
neoverse-n1: 0.9% faster

Imported from dav1d.

Approach taken from x86 asm. Overall speedup meaningless.
cabac_encode_terminal on average twice as fast on cortex-53 while
encoding with following command:
./x264 --threads 1 --profile high --preset veryfast --crf 15 -o /dev/null park_joy_420_720p50.y4m

Less relative speedup on cortex-a72/73.

Since 7ab4c928, osdep.h contains
calls to malloc/free.

This fixes building with MSVC targeting WinRT.

GPAC has native UTF-8 support nowadays.

Also move the compatibility code to input/avs.c since that's the only
remaining code that uses it now.

Should be called to free struct members allocated internally by libx264,
e.g. by x264_param_parse.
Partially based on videolan/x264!18 by Derek Buitenhuis.