Skip to content
Snippets Groups Projects

qml: merge MainContext and MainInterface

Merged Pierre Lamot requested to merge chub/vlc:qt/mainctx-merge into master

The rational for this change is:

  • MainContext doesn't have much value, most things it contains can be accessed through the MainInterface object.

  • MainInterface is no longer the interface with the QWidget meaning, but it's used as a context.

  • I needed Network models to access our MediaLib instance rather than directly the vlc_medialibrary_t instance for a future MR

  • using a QML singleton rather than a context property should provide a more efficient name resolution.

Note that I can live without the renaming if you don't like it.

Tests are welcomes, I didn't see any regression, but it touches pretty much every QML files

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
Please register or sign in to reply
Loading