Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
  • VLC VLC
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 3,722
    • Issues 3,722
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 226
    • Merge requests 226
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • VideoLANVideoLAN
  • VLCVLC
  • Merge requests
  • !94

Add gapless support

  • Review changes

  • Download
  • Email patches
  • Plain diff
Open Thomas Guillem requested to merge tguillem/vlc:gapless/0 into master May 06, 2021
  • Overview 58
  • Commits 20
  • Pipelines 8
  • Changes 26

Gapless as a seamless transition between 2 audio media, this MR is not about cross-fading (not planned for VLC 4.0).

If gapless is enabled and possible, the vlc_player_t will load a new input_thread_t, in gapless mode, near the end of the current input_thread_t.

This input_thead_t in gapless mode will act as a normal input_thread_t except that it will be halted at the end of the buffering, waiting for a signal from the player to resume. The gapless preparation can be cancelled (if the user stop/seek/etc...).

The audio output is also modified to handle gapless. If an aout stream is notified to have a next stream playing (input_thread_t in gapless mode), it won't drain and stop at the end of the current stream.

I fixed the points discussed during the last VLC tech meeting https://code.videolan.org/videolan/vlc/-/wikis/Meetingreports/2020-10-04-VLC-Tech-Meeting-via-videoconf#gapless

  • Gapless is only enabled if the input can be paced (Use it only for file-based access: file, smb, nfs...)
  • Gapless is only enabled when playing only one audio ES (that drive the block == master)
  • It can only work if the reported input time and length are correct
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: gapless/0

VideoLAN code repository instance