Add file stat properties in the input item

New version of !509 (closed)

It uses the already existing info_t API, and only one LibVLC function is created to recover 'stat' properties.

Fix #25747 (closed)

changed milestone to %4.0

added Component::Core: Input label

mentioned in merge request !509 (closed)

mentioned in merge request !144 (closed)

If you're storing the data as string I'd tend to let the user handle whatever they want to do with the string directly instead of enforcing a conversion internally.

Additionally it would simplify the API by returning a char* instead of having to pass an output parameter and returning an error code

cf. man stat, or the various stat API used by our access modules, but most (if not all) properties are unsigned int. Therefore, I do think we should return an uint64_t here and simplify the API for the user.

As mentioned privately, this API could be a good candidate to expose a media's mimetype to libvlc, but returning an int systematically prevents this.

However my main point was that if you're storing a char* internally, I don't see why the API has to enforce it being returned as an int. I'm not opposed to having an additional int getter though

added 1 commit

• b6d506f2 - fixup! item: add created_item field in vlc_readdir_helper_additem function

Compare with previous version

marked this merge request as draft from tguillem/vlc@b6d506f2

Maybe, we should not expose the 'stat' attributes in the UI like that:

Categories, key and values are generally translated and human (or basic user) readable. This is not the case with "stat".

I propose to name the category "stat" or ".stat" so that GUIs can ignore categories starting with '.' or ''. They can choose to display hidden categories differently, handling translation and time conversion (to human readable) on their side.

added 161 commits

• b6d506f2...76b3ad36 - 145 commits from branch videolan:master
• 45c67fa0 - input_item: add info_category_IsHidden
• 9a7b901a - lua: don't show hidden info categories
• cf9ccc50 - qt: don't show hidden info categories
• 6a51835b - ncurses: don't show hidden info categories
• 82a6975f - macos: don't show hidden info categories
• c8a81e85 - cli: don't show hidden info categories
• eca7b5cd - item: add created_item field in vlc_readdir_helper_additem function
• d003965b - smb2: get mtime and the size of the item
• 62be684a - nfs: get mtime and the size of the item
• ec4cf7ae - sftp: get mtime and the size of the item
• e66495d2 - directory: get mtime and size of the item
• 7d9afa7e - dsm: get mtime and size for the item
• 19564617 - samba: get mtime and size of the item
• 3bc1cbbd - archive: get mtime and size of the item
• 3fa20dca - libvlc: add libvlc_media_get_stat
• fa5ce13e - test: media: test libvlc_media_get_stat()

Compare with previous version

marked this merge request as ready

resolved all threads

added MRStatus::InReview label