Documentation: QtGl sample: minor improvement
Switch to unique_ptr when adequate, and cleanup some part of the code.
Merge request reports
Activity
changed milestone to %4.0
added Component::Documentation label
added MRStatus::Reviewable label
added MRStatus::Acceptable label and removed MRStatus::Reviewable label
- Resolved by Hugo Beauzée-Luyssen
- Resolved by Hugo Beauzée-Luyssen
Minor nit, you're probably missing a word after "remove stray" in the 2nd commit
added MRStatus::InReview label and removed MRStatus::Acceptable label
added 295 commits
-
012cb97a...eca2d51b - 292 commits from branch
videolan:master
- fabcddd2 - doc: QtGL: switch to C++14
- 2b0c3dd9 - doc: QtGl: use std::unique_ptr<>
- f19a90c4 - doc: QtGl: use nullptr and remove stray
Toggle commit list-
012cb97a...eca2d51b - 292 commits from branch
added 1 commit
- 39f180f8 - doc: QtGl: use nullptr and remove stray comments
added MRStatus::Acceptable label and removed MRStatus::InReview label
added MRStatus::Accepted label and removed MRStatus::Acceptable label
MR Acceptance result
This MergeRequest has been Accepted! Congratulations.MR acceptance checks details:
-
MR should be considered mergeable by Gitlab -
Last pipeline should be successful -
MergeRequest should have at least one external review and/or vote -
All threads should be resolved, and score >= 0 -
MergeRequest should have no activity (threads/votes) for (24h/24h)
-
added 16 commits
-
827ebab3...7577cfd2 - 13 commits from branch
videolan:master
- a6ab2189 - doc: QtGL: switch to C++14
- 530cc094 - doc: QtGl: use std::unique_ptr<>
- b225c6db - doc: QtGl: use nullptr and remove stray comments
Toggle commit list-
827ebab3...7577cfd2 - 13 commits from branch
enabled an automatic merge when the pipeline for b225c6db succeeds