qt: don't remove acrylic visual before UI thread update
fixes "sometimes acrylic disappear for a moment when clicking outside VLC window"
basically, we want this line[1] to execute before we remove acrylic visual from the visual tree but then the QML UI thread can take its own time to post an update which is not trackable, so the solution is to just wait it out, previously I used a QueuedConnection to do the same but it doesn't seem to work with certainty. This is probably the bug of #26279 (closed)
Merge request reports
Activity
added Component::Interface: Qt label
changed milestone to %4.0
added 1 commit
- 86f0b00e - qt: don't remove acrylic visual before UI thread update
added MRStatus::Reviewable label
Isn't acrylic effect integrated with the scene graph? As far as I know, such effect requires tight coupling with the scene graph. There are various signals in QQuickWindow, maybe you can use them instead of timers.
Edited by Fatih Uzunoğlu
added MRStatus::InReview label and removed MRStatus::Reviewable label
- Resolved by Prince Gupta
basically, we want this line[1] to execute before we remove acrylic visual from the visual tree but then the QML UI thread can take its own time to post an update which is not trackable, so the solution is to just wait it out, previously I used a QueuedConnection to do the same but it doesn't seem to work with certainty. This is probably the bug of #26279 (closed)
can't you connect to the
QQuickWindow::afterRendering
or theQQuickWindow::frameSwapped
signal?
mentioned in merge request !925 (merged)