qt: save genre cover in medialibrary

Aim

the main goal of this MR is qt/mlgenremodel: remove index usage from cover generation. This would be helpful to generalize the MlBaseModel::data function to only take MLItem ptr (basically omit the knowledge of source index to the function). I need that for a new async API in MLBaseModel i.e MLBaseModel::loadData(indices, callback) which can be used at places where we need to access the MLItem with certainty like when dropping items into the playlist.

Implementation

The cost of removal of index usage for cover generation is a linear search which shouldn't be a problem since something like that is already being done for handling ml cover generation signal but to minimize it I now save the cover directly into the media library so that removes the further need of cover generation.

Something similar would need to be implemented for PlayListModel and GroupListModel as well.

changed the description

added MRStatus::Reviewable label

requested review from @chouquette

added Component::Interface: Qt label

changed milestone to %Qt redesign (VLC 4.0)

added MRStatus::InReview label and removed MRStatus::Reviewable label

added 4 commits

• 1b475173 - medialibrary: add thumbnail to vlc_ml_genre_t
• 32cb23b4 - medialibrary: add VLC_ML_MEDIA_SET_GENRE_THUMBNAIL
• 79d7ad35 - qt: save genre covers in medialibrary
• 3c796a4c - qt/mlgenremodel: remove index usage from cover generation

Compare with previous version

resolved all threads

resolved all threads

added 5 commits

• cde10cbc - medialibrary: add thumbnail to vlc_ml_genre_t
• 4b9fc91a - medialibrary: add VLC_ML_MEDIA_SET_GENRE_THUMBNAIL
• da73417a - qt: save genre covers in medialibrary
• b5643b40 - qt/mlgenremodel: remove index usage from cover generation
• 47fc0056 - medialibrary: use strdup_helper for converting thumbnails

Compare with previous version

resolved all threads

added 3 commits

• 48d9c3a8 - qt: save genre covers in medialibrary
• 33925501 - qt/mlgenremodel: remove index usage from cover generation
• 1d395a6c - medialibrary: use strdup_helper for converting thumbnails

Compare with previous version

resolved all threads

added MRStatus::Acceptable label and removed MRStatus::InReview label

added MRStatus::Accepted label and removed MRStatus::Acceptable label

MR Acceptance result

This MergeRequest has been Accepted! Congratulations.

MR acceptance checks details:

• MR should be considered mergeable by Gitlab
• Last pipeline should be successful
• MergeRequest should have at least one external review and/or vote
• All threads should be resolved, have votes and score > 0
• MergeRequest should have no activity (threads/votes) for (72h/72h)

This message was automatically generated by homer-bot.

added 58 commits

• 1d395a6c...52424a5e - 53 commits from branch videolan:master
• 329758a9 - medialibrary: add thumbnail to vlc_ml_genre_t
• 3b1c3d72 - medialibrary: add VLC_ML_MEDIA_SET_GENRE_THUMBNAIL
• b561da29 - qt: save genre covers in medialibrary
• 0aa159f2 - qt/mlgenremodel: remove index usage from cover generation
• cd90cf5a - medialibrary: use strdup_helper for converting thumbnails

Compare with previous version

enabled an automatic merge when the pipeline for cd90cf5a succeeds

merged