Skip to content
Snippets Groups Projects

youtube.lua: descramble "n" URL parameter to fix throttling issue

Merged Pierre Ynard requested to merge linkfanel/vlc:26174 into master
1 unresolved thread

YouTube playback is currently broken due to heavy data transfer throttling that was fully rolled out last week, see #26174 (closed) This is similar to the URL signature scrambling, and is solved here reusing the same proven design. Although the descrambling javascript for this is an order of magnitude more complex than for URL signatures, it's still fairly workable; considering the hindsight other analysts have provided since the apparition of the feature back in June, I'm fairly confident this solution will be as sustainable as the URL signature descrambling. The implementation still lacks more live testing over time, but I see no reason to withhold an initial release.

If approved, please merge and backport this to 3.0 without unnecessary delay, as people are looking forward to this fix to restore the feature.

Edited by Rémi Denis-Courmont

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Pierre Ynard added 1 commit

    added 1 commit

    • 069816e9 - youtube.lua: descramble "n" video URL parameter by parsing javascript

    Compare with previous version

  • Pierre Ynard resolved all threads

    resolved all threads

  • Author Developer

    New descrambler version was finally rolled out today, MR updated to fix up some code that wasn't run at the time I wrote it.

  • MR Acceptance result

    :tada: This MergeRequest has been Accepted! Congratulations.

    MR acceptance checks details:

    • :white_check_mark: MR should be considered mergeable by Gitlab
    • :white_check_mark: Last pipeline should be successful
    • :white_check_mark: MergeRequest should have at least one external review and/or vote
    • :white_check_mark: All threads should be resolved, and score >= 0
    • :white_check_mark: MergeRequest should have no activity (threads/votes) for (24h/24h)

    This message was automatically generated by homer-bot.

  • Rémi Denis-Courmont approved this merge request

    approved this merge request

  • Pierre Ynard added 21 commits

    added 21 commits

    • 069816e9...3379c7bd - 13 commits from branch videolan:master
    • b2c32b5e - youtube.lua: add extra "out of use" comment
    • c7b4efcf - youtube.lua: remove fallback to retired alternate video info API
    • a1786912 - youtube.lua: fix up signature descrambling function name extraction
    • 8473b3bf - youtube.lua: rework error handling for signature descrambling
    • 095f0930 - youtube.lua: rename signature descrambling function
    • 4cfa8b65 - youtube.lua: factor out descrambling javascript fetching
    • f3963e68 - youtube.lua: retry fetching descrambling javascript asset once
    • 03e69578 - youtube.lua: descramble "n" video URL parameter by parsing javascript

    Compare with previous version

  • Hugo Beauzée-Luyssen enabled an automatic merge when the pipeline for 03e69578 succeeds

    enabled an automatic merge when the pipeline for 03e69578 succeeds

  • Pierre Ynard resolved all threads

    resolved all threads

  • mentioned in issue #26221 (closed)

  • Hugo Beauzée-Luyssen mentioned in merge request !838 (merged)

    mentioned in merge request !838 (merged)

  • changed milestone to %3.0.17

  • Please register or sign in to reply
    Loading