core: split block_t into vlc_frame_t and block_t
This MR try to implement what we discussed during the last Tech meeting: https://code.videolan.org/-/snippets/1313#block_t-and-ancillary
This is prerequisite from #18762 (closed)
This is not a draft: it builds as it is and doesn't require many changes, but it's only the beginning of the split work. If accepted, everyone can fix modules or CORE API one by one. I don't think it's necessary to finish the split for VLC 4.0
Merge request reports
Activity
changed milestone to %4.0
added Component::Core: Input label
- Resolved by Thomas Guillem
added 6 commits
Toggle commit listadded MRStatus::Acceptable label
- Resolved by Thomas Guillem
For the worse.. We had so many cases where the metadata needs to live between access and demux and decoders.
Supposing that would be a good idea, there's no need to create 2 new names to split one struct.
Naming "frame" something which (named Packet by ffmpeg) unlikely contains an audio frame, video frame or even packetized data but would output an AVFrame in avcodec is just aliasing for confusion. (And surprisingly data_t being still data in the worst unprocessed case)
mentioned in merge request !748 (merged)
added MRStatus::Accepted label and removed MRStatus::Acceptable label
MR Acceptance result
This MergeRequest has been Accepted! Congratulations.MR acceptance checks details:
-
MR should be considered mergeable by Gitlab -
Last pipeline should be successful -
MergeRequest should have at least one external review and/or vote -
All threads should be resolved, and score >= 0 -
MergeRequest should have no activity (threads/votes) for (24h/24h)
-
- Resolved by Thomas Guillem
Please wait before merging this. I have questions.
added MRStatus::InReview label and removed MRStatus::Accepted label
- Resolved by Thomas Guillem
"packet" wraps "data". We don't even need "packet" which is an alias for "block"
- Resolved by Thomas Guillem
- Resolved by Thomas Guillem
- Resolved by Thomas Guillem
- Resolved by Thomas Guillem
requested review from @typx
- Resolved by Thomas Guillem
- Resolved by Thomas Guillem
- Resolved by Thomas Guillem
- Resolved by Thomas Guillem
added MRStatus::NotCompliant label and removed MRStatus::InReview label
mentioned in issue #26378 (closed)
added 641 commits
-
c6be8e17...7577cfd2 - 633 commits from branch
videolan:master
- b021a5af - block: refactor block duplication
- 430299aa - core: move block.c to frame.c
- c3dabea9 - core: move block management from vlc_block.h to vlc_frame.h
- c944d601 - http: always use a block_t
- eac0fcf6 - core: rename block_t to vlc_frame_t
- 3666f888 - core: rename block_fifo_t to vlc_fifo_t
- 714957d2 - core: document block_t
- 637d0ec6 - vlc_codec: use vlc_frame_t
Toggle commit list-
c6be8e17...7577cfd2 - 633 commits from branch
- Resolved by Thomas Guillem
New version, addressing all the issues mentioned here and keeping the block_t name for access/stream as discussed in the workshop.
Opening a thread to prevent a merge.
added MRStatus::InReview label and removed MRStatus::NotCompliant label
added 80 commits
-
637d0ec6...c0ecf026 - 72 commits from branch
videolan:master
- c40c5839 - block: refactor block duplication
- 7d4b7445 - core: move block.c to frame.c
- 1313184e - core: move block management from vlc_block.h to vlc_frame.h
- d80fa1ed - http: always use a block_t
- eb74ee8e - core: rename block_t to vlc_frame_t
- 013a0800 - core: rename block_fifo_t to vlc_fifo_t
- f46be7d4 - core: document block_t
- 8856eae5 - vlc_codec: use vlc_frame_t
Toggle commit list-
637d0ec6...c0ecf026 - 72 commits from branch
- Resolved by Thomas Guillem
- Resolved by Thomas Guillem
added MRStatus::Acceptable label and removed MRStatus::InReview label
added MRStatus::Accepted label and removed MRStatus::Acceptable label
MR Acceptance result
This MergeRequest has been Accepted! Congratulations.MR acceptance checks details:
-
MR should be considered mergeable by Gitlab -
Last pipeline should be successful -
MergeRequest should have at least one external review and/or vote -
All threads should be resolved, and score >= 0 -
MergeRequest should have no activity (threads/votes) for (24h/24h)
-
added 67 commits
-
c0210a86...9958d3db - 59 commits from branch
videolan:master
- d1a5137a - block: refactor block duplication
- 0ba9fb3e - core: move block.c to frame.c
- 66dcab31 - core: move block management from vlc_block.h to vlc_frame.h
- 173b0ed2 - http: always use a block_t
- dd1c4288 - core: rename block_t to vlc_frame_t
- fbbc06b6 - core: rename block_fifo_t to vlc_fifo_t
- 27b52c24 - core: document block_t
- 543d402e - vlc_codec: use vlc_frame_t
Toggle commit list-
c0210a86...9958d3db - 59 commits from branch
enabled an automatic merge when the pipeline for 543d402e succeeds