Skip to content
Snippets Groups Projects

core: split block_t into vlc_frame_t and block_t

Merged Thomas Guillem requested to merge tguillem/vlc:block-split into master
All threads resolved!

This MR try to implement what we discussed during the last Tech meeting: https://code.videolan.org/-/snippets/1313#block_t-and-ancillary

This is prerequisite from #18762 (closed)

This is not a draft: it builds as it is and doesn't require many changes, but it's only the beginning of the split work. If accepted, everyone can fix modules or CORE API one by one. I don't think it's necessary to finish the split for VLC 4.0

Edited by Thomas Guillem

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Thomas Guillem added 6 commits

    added 6 commits

    • feff8a21 - core: move block.c to frame.c
    • ef5747db - core: move block management from vlc_block.h to vlc_frame.h
    • 3d323608 - core: rename block_t to vlc_frame_t
    • 36167312 - core: add vlc_data_t
    • e09cfe6f - vlc_stream: use vlc_data_t
    • c6be8e17 - vlc_codec: use vlc_frame_t

    Compare with previous version

  • Thomas Guillem resolved all threads

    resolved all threads

    • Resolved by Thomas Guillem

      For the worse.. We had so many cases where the metadata needs to live between access and demux and decoders.

      Supposing that would be a good idea, there's no need to create 2 new names to split one struct.

      Naming "frame" something which (named Packet by ffmpeg) unlikely contains an audio frame, video frame or even packetized data but would output an AVFrame in avcodec is just aliasing for confusion. (And surprisingly data_t being still data in the worst unprocessed case)

  • Thomas Guillem mentioned in merge request !748 (merged)

    mentioned in merge request !748 (merged)

  • MR Acceptance result

    :tada: This MergeRequest has been Accepted! Congratulations.

    MR acceptance checks details:

    • :white_check_mark: MR should be considered mergeable by Gitlab
    • :white_check_mark: Last pipeline should be successful
    • :white_check_mark: MergeRequest should have at least one external review and/or vote
    • :white_check_mark: All threads should be resolved, and score >= 0
    • :white_check_mark: MergeRequest should have no activity (threads/votes) for (24h/24h)

    This message was automatically generated by homer-bot.

  • Rémi Denis-Courmont
  • Rémi Denis-Courmont
  • Rémi Denis-Courmont
  • Rémi Denis-Courmont
  • Rémi Denis-Courmont requested review from @typx

    requested review from @typx

  • Denis Charmet
  • Denis Charmet
  • Denis Charmet
  • Denis Charmet
  • mentioned in issue #26378 (closed)

  • Thomas Guillem added 641 commits

    added 641 commits

    • c6be8e17...7577cfd2 - 633 commits from branch videolan:master
    • b021a5af - block: refactor block duplication
    • 430299aa - core: move block.c to frame.c
    • c3dabea9 - core: move block management from vlc_block.h to vlc_frame.h
    • c944d601 - http: always use a block_t
    • eac0fcf6 - core: rename block_t to vlc_frame_t
    • 3666f888 - core: rename block_fifo_t to vlc_fifo_t
    • 714957d2 - core: document block_t
    • 637d0ec6 - vlc_codec: use vlc_frame_t

    Compare with previous version

  • Thomas Guillem resolved all threads

    resolved all threads

  • Thomas Guillem added 80 commits

    added 80 commits

    • 637d0ec6...c0ecf026 - 72 commits from branch videolan:master
    • c40c5839 - block: refactor block duplication
    • 7d4b7445 - core: move block.c to frame.c
    • 1313184e - core: move block management from vlc_block.h to vlc_frame.h
    • d80fa1ed - http: always use a block_t
    • eb74ee8e - core: rename block_t to vlc_frame_t
    • 013a0800 - core: rename block_fifo_t to vlc_fifo_t
    • f46be7d4 - core: document block_t
    • 8856eae5 - vlc_codec: use vlc_frame_t

    Compare with previous version

  • Thomas Guillem added 4 commits

    added 4 commits

    • aecc4d88 - core: rename block_t to vlc_frame_t
    • 078c9ce9 - core: rename block_fifo_t to vlc_fifo_t
    • c86e0866 - core: document block_t
    • 3106f4d9 - vlc_codec: use vlc_frame_t

    Compare with previous version

  • Rémi Denis-Courmont
  • Rémi Denis-Courmont
  • Thomas Guillem changed title from core: split block_t into vlc_frame_t and vlc_data_t to core: split block_t into vlc_frame_t and block_t

    changed title from core: split block_t into vlc_frame_t and vlc_data_t to core: split block_t into vlc_frame_t and block_t

  • Thomas Guillem added 4 commits

    added 4 commits

    • ad224ac3 - core: rename block_t to vlc_frame_t
    • a129bf07 - core: rename block_fifo_t to vlc_fifo_t
    • d83a03f2 - core: document block_t
    • c0210a86 - vlc_codec: use vlc_frame_t

    Compare with previous version

  • Jean-Baptiste Kempf approved this merge request

    approved this merge request

  • Thomas Guillem resolved all threads

    resolved all threads

  • MR Acceptance result

    :tada: This MergeRequest has been Accepted! Congratulations.

    MR acceptance checks details:

    • :white_check_mark: MR should be considered mergeable by Gitlab
    • :white_check_mark: Last pipeline should be successful
    • :white_check_mark: MergeRequest should have at least one external review and/or vote
    • :white_check_mark: All threads should be resolved, and score >= 0
    • :white_check_mark: MergeRequest should have no activity (threads/votes) for (24h/24h)

    This message was automatically generated by homer-bot.

  • added 67 commits

    • c0210a86...9958d3db - 59 commits from branch videolan:master
    • d1a5137a - block: refactor block duplication
    • 0ba9fb3e - core: move block.c to frame.c
    • 66dcab31 - core: move block management from vlc_block.h to vlc_frame.h
    • 173b0ed2 - http: always use a block_t
    • dd1c4288 - core: rename block_t to vlc_frame_t
    • fbbc06b6 - core: rename block_fifo_t to vlc_fifo_t
    • 27b52c24 - core: document block_t
    • 543d402e - vlc_codec: use vlc_frame_t

    Compare with previous version

  • Jean-Baptiste Kempf enabled an automatic merge when the pipeline for 543d402e succeeds

    enabled an automatic merge when the pipeline for 543d402e succeeds

  • Please register or sign in to reply
    Loading