Skip to content
Snippets Groups Projects

Draft: vlc_aout: add vlc_audio_output_callbacks for device hotplug support in player

2 unresolved threads

The callbacks are similar to those from vlc_audio_output_events but are meant to forward to the interfaces/player instead of the audio output owner. They could be unified in later refactors.

The Qt interface doesn't implement the callback correctly yet, I'm waiting for approval on the way I plan to refactor the audio output events vlc_variable into the callback structure in input_resource.

Fixes #22478

Refs #22479

Edited by Alexandre Janniaux

Merge request reports

Members who can merge are allowed to add commits.

Merge request pipeline #145903 failed

Merge request pipeline failed for 37680964

Ready to merge by members who can write to the target branch.
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
136 136 int (*gain_request)(audio_output_t *, float);
137 137 };
138 138
139 struct vlc_audio_output_callbacks {
  • This seems out of place (and confusingly named), as it is not actually used by audio_output.

  • This is a owner-like callback structure, much like vout_window_callbacks, except that the audio output codes adds an intermediate layer between the owner of the audio output and its implementation (I'd call that private core part). In the end, factoring the private code part out of the audio output to match vout_window could be a possibility but it means that we typically loose the device cache.

    It's provided through the input resource, because though the input resource will store it, it's not the client of the audio output but would still create the audio output.

  • Please register or sign in to reply
Please register or sign in to reply
Loading