Draft: Update App-Icons for macOS to fit Big Sur Design Language
I changed the icons to better fit the Big Sur design language as this version is out almost a year. I chose a background consisting of a grey-white gradient as it looks a bit like asphalt were we mostly find traffic cones as the logo.
Merge request reports
Activity
Thanks
Thanks for your contribution!
When all of the following conditions are fulfilled, your MergeRequest will be reviewed by the Team:
- the check pipeline passes
- the MR is considered as 'mergeable' by gitlab
You can find more details about the acceptance process here.
added MRStatus::Reviewable label
requested review from @fkuehne
I created the files with sketch, therefore, by now, there is no svg available. Please find the sketch workspaces attached.
Best, Rafael
- Resolved by David
/cc @dfuhrmann opinion needed. also on whether we would want to back-port to 3.x.
added MRStatus::InReview label and removed MRStatus::Reviewable label
added MRStatus::Acceptable label and removed MRStatus::InReview label
added MRStatus::InReview label and removed MRStatus::Acceptable label
changed milestone to %3.0.17
added MRStatus::Accepted label and removed MRStatus::InReview label
MR Acceptance result
This MergeRequest has been Accepted! Congratulations.MR acceptance checks details:
-
MR should be considered mergeable by Gitlab -
Last pipeline should be successful -
MergeRequest should have at least one external review and/or vote -
All threads should be resolved, have votes and score > 0 -
MergeRequest should have no activity (threads/votes) for (72h/72h)
-
@rafiv can you check the option in your MR to allow patches from other contributions so I can rebase and merge? Thank you!
added MRStatus::InReview label and removed MRStatus::Accepted label
added MRStatus::Acceptable label and removed MRStatus::InReview label
No problem. I think the only way is to close this MR and make a new one, with a new branch from your current master (for example
git switch -c rafiv-new-macosx-icon
) then check out the master branch again (git switch master
) and reset it to upstream master:git reset --hard origin/master
. Be careful with the last one, make sure to run it on the right branch as it will erase all changes between the current branch to make it match origin/master again.After that you can just push the
rafiv-new-macosx-icon
branch and open a new MR with that. However as this MR has ongoing discussion, probably just wait for the outcome for now, unless you want to submit other MRs in the meantime.
added MRStatus::Accepted label and removed MRStatus::Acceptable label
MR Acceptance result
This MergeRequest has been Accepted! Congratulations.MR acceptance checks details:
-
MR should be considered mergeable by Gitlab -
Last pipeline should be successful -
MergeRequest should have at least one external review and/or vote -
All threads should be resolved, have votes and score > 0 -
MergeRequest should have no activity (threads/votes) for (72h/72h)
-
changed milestone to %3.0.x maintenance
removed MRStatus::Accepted label
changed milestone to %4.0
- Resolved by FeRD (Frank Dana)
I know this is a 2-year-old MR, but... does VLC change its application icon based on the date, in macOS?
On Linux, the "Santa-hat" image is only ever shown in the background of the VLC window when idle. If it's used the same way on macOS, redesigning that image with a gradient background doesn't really make sense to me. But I've never run VLC on a Mac, so I could be missing something.
Edited by FeRD (Frank Dana)
mentioned in merge request !6642
added Component::Interface: macOS label