macosx: VLCTimeField: do not use identifier

Overriding setIdentifier is something that should not be done and also that identifier is supposed to be unique so it is not really suitable for our use-case here.

Additionally on older macOS versions this selector is sometimes called with a nil identifier leading to a crash.

Just go back to a dedicated property for this without hooking into the view identifier.

assigned to @ePirat

requested review from @claucambra

added Component::Interface: macOS label

changed milestone to %4.0

added MRStatus::WaitingForReviewerFeedback label

approved this merge request

added MRStatus::Acceptable label and removed MRStatus::WaitingForReviewerFeedback label

added MRStatus::Accepted label and removed MRStatus::Acceptable label

MR Acceptance result

This MergeRequest has been Accepted! Congratulations.

MR acceptance checks details:

• MR should be considered mergeable by Gitlab
• Last pipeline should be successful
• MergeRequest should have at least one external review and/or vote
• All threads should be resolved, and score >= 0
• MergeRequest should have no activity (threads/votes) for (24h/24h)

This message was automatically generated by homer-bot.

approved this merge request

added 12 commits

• 094c7232...4bb2f7d4 - 11 commits from branch videolan:master
• 6434ab75 - macosx: VLCTimeField: do not use identifier

Compare with previous version

enabled an automatic merge when all merge checks for 6434ab75 pass

merged