qt: fix missing disconnect in `VideoSurface`
Unfortunately, I forgot to disconnect if the connection is made to QQuickWindow::afterAnimating()
(no support for threaded surface updates). This is currently not a problem, because we are not assigning different windows to video surface but we still need to fix it.
Request review @chub.
Merge request reports
Activity
added 1 commit
- 3c0220f6 - qt: fix missing disconnect in `VideoSurface`
added MRStatus::Reviewable label
changed milestone to %4.0
added Component::Interface: Qt label
requested review from @chub
added MRStatus::WaitingForReviewerFeedback label and removed MRStatus::Reviewable label
added MRStatus::Acceptable label and removed MRStatus::WaitingForReviewerFeedback label
added MRStatus::Accepted label and removed MRStatus::Acceptable label
MR Acceptance result
This MergeRequest has been Accepted! Congratulations.MR acceptance checks details:
-
MR should be considered mergeable by Gitlab -
Last pipeline should be successful -
MergeRequest should have at least one external review and/or vote -
All threads should be resolved, have votes and score > 0 -
MergeRequest should have no activity (threads/votes) for (72h/72h)
-
added 63 commits
-
3c0220f6...0c2d3d4e - 62 commits from branch
videolan:master
- 826ae377 - qt: fix missing disconnect in `VideoSurface`
-
3c0220f6...0c2d3d4e - 62 commits from branch
enabled an automatic merge when all merge checks for 826ae377 pass