contrib: qt: accept using qt tools that have different patch version
Supersedes !5737 (closed).
Merge request reports
Activity
added 1 commit
- 9eebc421 - Partial revert "contrib: qt: only allow using the exact same version of native tools"
added MRStatus::NotCompliant label
added MRStatus::Reviewable label and removed MRStatus::NotCompliant label
changed milestone to %4.0
added Component::Build system: Contribs label
requested review from @chub
added MRStatus::WaitingForReviewerFeedback label and removed MRStatus::Reviewable label
- Resolved by Steve Lhomme
The Merge Request is missing the why we would want to do this.
added MRStatus::Acceptable label and removed MRStatus::WaitingForReviewerFeedback label
- Resolved by Fatih Uzunoğlu
Why is this safe to do? My understanding was that it isnt from what I remember, especially for the QML tools?
added MRStatus::InReview label and removed MRStatus::Acceptable label
added MRStatus::Acceptable label and removed MRStatus::InReview label
added MRStatus::Accepted label and removed MRStatus::Acceptable label
MR Acceptance result
This MergeRequest has been Accepted! Congratulations.MR acceptance checks details:
-
MR should be considered mergeable by Gitlab -
Last pipeline should be successful -
MergeRequest should have at least one external review and/or vote -
All threads should be resolved, have votes and score > 0 -
MergeRequest should have no activity (threads/votes) for (72h/72h)
-
added 164 commits
-
b69cba12...c30713a3 - 161 commits from branch
videolan:master
- f6e166f0 - contrib: qtdeclarative: add patch to not care about patch version when checking QML cache
- bcf1aa5e - Reapply "contrib: qt: allow using Qt tools with different patch version"
- 59da34a2 - Partial revert "contrib: qt: only allow using the exact same version of native tools"
Toggle commit list-
b69cba12...c30713a3 - 161 commits from branch
enabled an automatic merge when all merge checks for 59da34a2 pass