Skip to content
Snippets Groups Projects

libass: create a dummy dummy to tell the core the regions will be absolute

Closed Steve Lhomme requested to merge robUx4/vlc:libass-absolute into master
1 unresolved thread

The core uses IsSubpicInVideo() to determine if the subpicture should be rendered inside the video. In most cases the subpictures with the b_subtitle flag (start and stop times) signal a subtitle SPU. But for libass it's not supposed to be rendered outside of the video. It has to match the video location.

IsSubpicInVideo() can't tell if the regions are absolute (positioned inside the video) unless there's an actual region. So we create a dummy one with the b_absolute flag.

A cleaner way would be to add a flag to subpicture_t to signal we allow subpictures in black bars or not. This will need to be checked for each subpicture source.

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
371 371 .ops = &spu_ops,
372 372 };
373 373
374
  • Author Developer

    Not needed anymore after !6952 (merged)

  • closed

  • Please register or sign in to reply
    Loading