Remove undeeded assert.

This breaks compatibility with some legacy over the air mpegts content on US feeds.

changed milestone to %4.0

added Component::Core: Clock label

That's actually not correct, it should always be locked when the function is used. ;)

I have a live TV Channel, over the air 8VSB/UHF, multi-program mpegts stream (I can upload a sample) ... It works/plays fine on VLC3 but crashes on that line on VLC4. If I remove the line, it works ... Don't know enough about this part of the codebase to elaborate further.

May I send another patch with your co-author on it to fix this ?

I'd love a sample! You can send here or to ajanni@ vlabs

Absolutely, patch and co-authorship are welcome. I will email you a sample shortly.

Done in !6887 (merged) ! Thanks for the sample, unfortunately, I wasn't able to reproduce with it. But I wrote a test to check the hypothesis on the multiple program usage and it did trigger the assertion too.

I can confirm the new patch fixes the issue, thank you!

src/input/es_out.c-        case VLC_CLOCK_MASTER_INPUT:
src/input/es_out.c-        {
src/input/es_out.c-            vlc_clock_main_Lock(p_sys->p_pgrm->clocks.main);
src/input/es_out.c-            p_pgrm->clocks.input =
src/input/es_out.c:                vlc_clock_main_CreateInputMaster(p_pgrm->clocks.main);
src/input/es_out.c-            vlc_clock_main_Unlock(p_sys->p_pgrm->clocks.main);
src/input/es_out.c-

wild guess is that in case of program switching, p_sys->p_pgrm and p_pgrm are not the same.

added MRStatus::InReview label

mentioned in merge request !6887 (merged)

closed