qt: fix artist view regressions
See individual commits.
- Initial selection should not be the first item. Views should not have a selection initially. This seems to be an old bug, now it is exposed.
- Clicking a delegate does not change the current index.
- Functioning of double clicking list view delegate is broken due to "Error: Insufficient arguments".
Regressions since !6687 (merged).
Request review @chub.
Merge request reports
Activity
added 1 commit
- de180fbd - qml: fix emitting a signal without required parameters in `MusicAllArtists.qml`
added MRStatus::Reviewable label
- Resolved by Fatih Uzunoğlu
Regardless, having such signal is not meaningful because there is already
currentIndex
The idea was to avoid using the currentIndex as this is what led us to this situation, though your patch should be fine here as we're not cross referencing models.
At the same time,
currentIndex
should be used instead of the first selected item when view is requested.This looks brittle, we should rather fix the calling sites to pass the id properly
added MRStatus::InReview label and removed MRStatus::Reviewable label
added 1 commit
- c5038f7a - qml: fix emitting a signal without required parameters in `MusicAllArtists.qml`
added 1 commit
- e67eae79 - qml: add required property `model` to `MusicArtist` header delegate
added Component::Interface: Qt label
changed milestone to %4.0
added MRStatus::Acceptable label and removed MRStatus::InReview label
added MRStatus::Accepted label and removed MRStatus::Acceptable label
MR Acceptance result
This MergeRequest has been Accepted! Congratulations.MR acceptance checks details:
-
MR should be considered mergeable by Gitlab -
Last pipeline should be successful -
MergeRequest should have at least one external review and/or vote -
All threads should be resolved, have votes and score > 0 -
MergeRequest should have no activity (threads/votes) for (72h/72h)
-
added 62 commits
-
e67eae79...892cf452 - 58 commits from branch
videolan:master
- 978a7308 - qml: do not change selection within `resetFocus()` in `MusicArtistsAlbums`
- 913454c4 - qml: get rid of `showArtist()` signal in `MusicArtistsAlbums.qml`
- 738520b6 - qml: fix emitting a signal without required parameters in `MusicAllArtists.qml`
- 963887b3 - qml: add required property `model` to `MusicArtist` header delegate
Toggle commit list-
e67eae79...892cf452 - 58 commits from branch
enabled an automatic merge when all merge checks for 963887b3 pass