qt: fix improper layouting occurring in top bar when the page changes
This fixes the layouting issue where the cone bar overlaps with the menu bar when the page changes (such as, switching to player view).
!3385 (merged) already showed how bad imperative layouting can get, I think we need to refactor this file to do the layouting declaratively (if necessary, with delayed bindings).
Request review @chub.
Merge request reports
Activity
added MRStatus::Reviewable label
added Component::Interface: Qt label
changed milestone to %4.0
added MRStatus::Acceptable label and removed MRStatus::Reviewable label
added MRStatus::Accepted label and removed MRStatus::Acceptable label
MR Acceptance result
This MergeRequest has been Accepted! Congratulations.MR acceptance checks details:
-
MR should be considered mergeable by Gitlab -
Last pipeline should be successful -
MergeRequest should have at least one external review and/or vote -
All threads should be resolved, have votes and score > 0 -
MergeRequest should have no activity (threads/votes) for (72h/72h)
-
added 33 commits
-
b33e8a1d...80868bba - 32 commits from branch
videolan:master
- 2a0f7735 - qml: re-layout when implicit height of menu bar changes in `TopBar.qml`
-
b33e8a1d...80868bba - 32 commits from branch
enabled an automatic merge when all merge checks for 2a0f7735 pass