Skip to content
Snippets Groups Projects

qt: fix improper layouting occurring in top bar when the page changes

Merged Fatih Uzunoğlu requested to merge fuzun/vlc:qt/fixtopbarlayouting into master

This fixes the layouting issue where the cone bar overlaps with the menu bar when the page changes (such as, switching to player view).

!3385 (merged) already showed how bad imperative layouting can get, I think we need to refactor this file to do the layouting declaratively (if necessary, with delayed bindings).

image

Request review @chub.

Merge request reports

Merge request pipeline #561485 passed

Merge request pipeline passed for 2a0f7735

Test coverage 17.72% (-0.00%) from 1 job
Test summary results are loading

Merged by Steve LhommeSteve Lhomme 1 week ago (Feb 1, 2025 10:59am UTC)

Loading

Pipeline #561490 passed

Pipeline passed for 2a0f7735 on master

Test coverage 17.72% (-0.00%) from 1 job

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
Please register or sign in to reply
Loading