Skip to content
Snippets Groups Projects

qt: add missing disconnect in `VideoSurface`

Merged Fatih Uzunoğlu requested to merge fuzun/vlc:qt/disconnectinvideosurface into master
All threads resolved!

It seems that two disconnect() calls are missing.

Request review @chub.

Merge request reports

Merge request pipeline #561545 passed

Merge request pipeline passed for 6e67d031

Test coverage 17.73% (-0.22%) from 1 job
Approved by
Test summary results are loading

Merged by Steve LhommeSteve Lhomme 1 week ago (Feb 1, 2025 2:00pm UTC)

Merge details

  • Changes merged into master with 6e67d031.
  • Deleted the source branch.
  • Auto-merge enabled

Pipeline #561550 passed

Pipeline passed for 6e67d031 on master

Test coverage 17.72% (-0.22%) from 1 job

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Fatih Uzunoğlu added 1 commit

    added 1 commit

    • 979e4cc9 - qt: add missing disconnect in `VideoSurface`

    Compare with previous version

  • Fatih Uzunoğlu resolved all threads

    resolved all threads

  • Pierre Lamot approved this merge request

    approved this merge request

  • Pierre Lamot changed milestone to %4.0

    changed milestone to %4.0

  • MR Acceptance result

    :tada: This MergeRequest has been Accepted! Congratulations.

    MR acceptance checks details:

    • :white_check_mark: MR should be considered mergeable by Gitlab
    • :white_check_mark: Last pipeline should be successful
    • :white_check_mark: MergeRequest should have at least one external review and/or vote
    • :white_check_mark: All threads should be resolved, have votes and score > 0
    • :white_check_mark: MergeRequest should have no activity (threads/votes) for (72h/72h)

    This message was automatically generated by homer-bot.

  • Steve Lhomme added 77 commits

    added 77 commits

    Compare with previous version

  • Steve Lhomme enabled an automatic merge when all merge checks for 6e67d031 pass

    enabled an automatic merge when all merge checks for 6e67d031 pass

  • merged

  • Please register or sign in to reply
    Loading