emscripten: ban incompatible function casts
Emscripten is known to deal badly with function casts to incompatible types 1. This patch prevents us to accidentally merge harmful UB casts to wasm enabled code. The warning is really strict but is compliant to the standard. Code that wants to use function cast should be disabled from the wasm platform.
Merge request reports
Activity
changed milestone to %4.0
added Component::Build system Platform::Wasm labels
requested review from @alexandre-janniaux
- Resolved by Alaric Senat
added MRStatus::InReview label
- Resolved by Alexandre Janniaux
added MRStatus::Acceptable label and removed MRStatus::InReview label
mentioned in merge request !6757 (merged)
added MRStatus::Accepted label and removed MRStatus::Acceptable label
MR Acceptance result
This MergeRequest has been Accepted! Congratulations.MR acceptance checks details:
-
MR should be considered mergeable by Gitlab -
Last pipeline should be successful -
MergeRequest should have at least one external review and/or vote -
All threads should be resolved, and score >= 0 -
MergeRequest should have no activity (threads/votes) for (24h/24h)
-
added 104 commits
-
973f0ae5...837f9778 - 100 commits from branch
videolan:master
- 61c4034f - mpeg: dvbpsi: avoid casting callbacks
- e99be279 - libplacebo: avoid casting callbacks
- c876b0f7 - emscripten: extra_checks: ban incompatible function casts
- a7f92685 - configure: misc: fix some typos
Toggle commit list-
973f0ae5...837f9778 - 100 commits from branch
enabled an automatic merge when all merge checks for a7f92685 pass