Skip to content
Snippets Groups Projects

emscripten: ban incompatible function casts

Merged Alaric Senat requested to merge asenat/vlc:wasm-strict-function-cast into master
All threads resolved!

Emscripten is known to deal badly with function casts to incompatible types 1. This patch prevents us to accidentally merge harmful UB casts to wasm enabled code. The warning is really strict but is compliant to the standard. Code that wants to use function cast should be disabled from the wasm platform.

  1. https://emscripten.org/docs/porting/guidelines/function_pointer_issues.html

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Romain Vimont approved this merge request

    approved this merge request

  • Alaric Senat added 3 commits

    added 3 commits

    • 66e61703 - libplacebo: avoid casting callbacks
    • 755d8c81 - emscripten: extra_checks: ban incompatible function casts
    • 973f0ae5 - configure: misc: fix some typos

    Compare with previous version

  • Alexandre Janniaux resolved all threads

    resolved all threads

  • Alexandre Janniaux approved this merge request

    approved this merge request

  • Steve Lhomme mentioned in merge request !6757 (merged)

    mentioned in merge request !6757 (merged)

  • MR Acceptance result

    :tada: This MergeRequest has been Accepted! Congratulations.

    MR acceptance checks details:

    • :white_check_mark: MR should be considered mergeable by Gitlab
    • :white_check_mark: Last pipeline should be successful
    • :white_check_mark: MergeRequest should have at least one external review and/or vote
    • :white_check_mark: All threads should be resolved, and score >= 0
    • :white_check_mark: MergeRequest should have no activity (threads/votes) for (24h/24h)

    This message was automatically generated by homer-bot.

  • Steve Lhomme added 104 commits

    added 104 commits

    • 973f0ae5...837f9778 - 100 commits from branch videolan:master
    • 61c4034f - mpeg: dvbpsi: avoid casting callbacks
    • e99be279 - libplacebo: avoid casting callbacks
    • c876b0f7 - emscripten: extra_checks: ban incompatible function casts
    • a7f92685 - configure: misc: fix some typos

    Compare with previous version

  • Steve Lhomme enabled an automatic merge when all merge checks for a7f92685 pass

    enabled an automatic merge when all merge checks for a7f92685 pass

  • merged

  • Please register or sign in to reply
    Loading