Skip to content
Snippets Groups Projects

vout_subpictures: avoid converting invalid timestamps

Merged Alaric Senat requested to merge asenat/vlc:ephemeral-ts-conv into master
All threads resolved!

Ephemeral subtitles stop timestamps are often undefined. Converting them with the clock can lead to unexpected behavior.

This fixes an assert failure with some ephemeral DVD SPUs:

Assertion failed: ctx->wait_sync_ref.stream != VLC_TICK_INVALID, at: src/clock/clock.c,582

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Steve Lhomme resolved all threads

    resolved all threads

  • Thomas Guillem approved this merge request

    approved this merge request

  • MR Acceptance result

    :tada: This MergeRequest has been Accepted! Congratulations.

    MR acceptance checks details:

    • :white_check_mark: MR should be considered mergeable by Gitlab
    • :white_check_mark: Last pipeline should be successful
    • :white_check_mark: MergeRequest should have at least one external review and/or vote
    • :white_check_mark: All threads should be resolved, and score >= 0
    • :white_check_mark: MergeRequest should have no activity (threads/votes) for (24h/24h)

    This message was automatically generated by homer-bot.

  • Steve Lhomme added 40 commits

    added 40 commits

    Compare with previous version

  • Steve Lhomme enabled an automatic merge when all merge checks for ae69d42e pass

    enabled an automatic merge when all merge checks for ae69d42e pass

  • merged

  • Please register or sign in to reply
    Loading