Skip to content

help: fix `vlc -p` confusion

Lyndon Brown requested to merge jnqnfe/vlc:help1 into master

In cases like vlc -p pulse you confusingly get an error stating that no matching module was found and to look in the list generated by vlc --list, yet the latter output does in fact contain a module with that name (system dependent).

The cause is that the pulse module has no options (nor pulsesrc/pulselist), and the underlying logic is geared primarily towards --full-help/--longhelp output which deliberately skips over such modules.

This tweaks the logic to include them for -p mode.

Old output:

lyndon@desktop ~$ vlc -p pulse
VLC media player 4.0.0-dev Otto Chriek (revision 4.0.0-dev-15406-g183c8d9971)

No matching module found. Use --list or --list-verbose to list available modules.

New output:

lyndon@desktop ~$ vlc -p pulse
VLC media player 4.0.0-dev Otto Chriek (revision 4.0.0-dev-15407-g19c204c671)

 Pulseaudio audio output (pulse)
  This module has no options.

 PulseAudio input (pulsesrc)
 Pass pulse:// to open the default PulseAudio source, or pulse://SOURCE to open a specific source named SOURCE.
  This module has no options.

 Audio capture (PulseAudio) (pulselist)
  This module has no options.

(Was in !60 (merged), but in making a v2 of that work, I felt this did not belong).

Edited by Lyndon Brown

Merge request reports

Loading