macosx: Improve continue playback behaviour
- Fix issue with continuing playback detection for media library items
- Adds ability to retrieve options from
VLCInputItem
- Reimplements dead code for detecting custom start/stop time on input items and not asking to continue playback
Signed-off-by: Claudio Cambra developer@claudiocambra.com
Merge request reports
Activity
Filter activity
changed milestone to %4.0
added Component::Interface: macOS Platform::macOS labels
assigned to @claucambra
added MRStatus::Reviewable label
added MRStatus::Accepted label and removed MRStatus::Reviewable label
MR Acceptance result
This MergeRequest has been Accepted! Congratulations.MR acceptance checks details:
-
MR should be considered mergeable by Gitlab -
Last pipeline should be successful -
No activity on MR (no thread, no vote) and last update is long enough
-
added 256 commits
-
c9a4f550...cde627b0 - 248 commits from branch
videolan:master
- 623a4bf1 - macosx: Constify variables in resume library media item playback
- bfcb5276 - macosx: Just take input item from media library item when resuming playback
- 5007f5a8 - macosx: Assert media item being not nil
- 886c127c - macosx: Use playerController durationOfCurrentMediaItem to get duration to resume playback
- 8ddeb935 - macosx: Add options property to VLCInputItem
- 7de9fa56 - macosx: Do not suggest continuing playback if start/stop time is in input item options
- 18fbe621 - macosx: Improve options getter in input item
- d628a8de - macosx: Remove dead start/stop time handlng in playback continuity controller
Toggle commit list-
c9a4f550...cde627b0 - 248 commits from branch
enabled an automatic merge when all merge checks for d628a8de pass
Please register or sign in to reply