macosx: Refactor handling of library view segments
This PR mainly makes the segment abstraction less leaky by allowing polymorphism to take care of the specifics of the various ways in which library segments need the library window and their view controllers to be prepared
Additionally this PR fixes a few issues in the media source views due to how some of the view components have been moved around (particularly with the navigation stack)
Signed-off-by: Claudio Cambra developer@claudiocambra.com
Merge request reports
Activity
changed milestone to %4.0
added Component::Interface: macOS Platform::macOS labels
assigned to @claucambra
added MRStatus::Reviewable label
added MRStatus::Accepted label and removed MRStatus::Reviewable label
MR Acceptance result
This MergeRequest has been Accepted! Congratulations.MR acceptance checks details:
-
MR should be considered mergeable by Gitlab -
Last pipeline should be successful -
No activity on MR (no thread, no vote) and last update is long enough
-
added 194 commits
-
0a302d3d...8048d4ed - 137 commits from branch
videolan:master
- 8048d4ed...33e68ab3 - 47 earlier commits
- 2642e9a0 - macosx: Add method to save the view mode on the segment
- 83677bc2 - macosx: Use saveViewMode method rather than using switch case again
- f3722d89 - macosx: Convert viewMode in segment into a readwrite property
- 12588118 - macosx: Use viewMode setter on VLCLibrarySegment instead of switch in...
- 24f520a1 - macosx: Add applyVisibilityFlags: convenience method to toolbar delegate
- 46ad9f3c - macosx: Use applyvisibility method in toolbar delegate switch
- cbb3347c - macosx: Provide toolbarDisplayFlags in VLCLibrarySegment
- 030e7913 - macosx: Use applyVisibilityFlags with segment toolbarDisplayFlags in library window
- c07296c6 - macosx: Remove layoutForSegment
- bd4df03d - macosx: Document segment subclasses
Toggle commit list-
0a302d3d...8048d4ed - 137 commits from branch
enabled an automatic merge when all merge checks for bd4df03d pass
@robUx4 why did you merge despite the "f" commit ?
Edited by Alexandre Janniaux