modules: freetype: fix outline styles
My first patch to VLC fixing an issue where the outlines and shadows of subtitles would not be formatted with the same style as the actual glyph.
I believe the wrong style flags were given to vlc_ftcache_GetOutlinedGlyph
: instead of passing it the style flags of the current run, we were giving it the style flags of the glyph from the font face. This would result in incorrect cache hits (or misses?).
Merge request reports
Activity
Thanks
Thanks for your contribution!
When all of the following conditions are fulfilled, your MergeRequest will be reviewed by the Team:
- the check pipeline passes
- the MR is considered as 'mergeable' by gitlab
You can find more details about the acceptance process here.
added MRStatus::Reviewable label
Nice ! Thanks for the patch.
Cc @fcartegnie for the review
changed milestone to %4.0
added Component::Text Rendering label
The change was introduced in e2a62698.
The result looks good but there's this comment in the code above:
/* !warn: style STYLE_OUTLINE != glyph FORMAT_OUTLINE */
Not sure if it's relevant.
requested review from @fcartegnie
added MRStatus::WaitingForReviewerFeedback label and removed MRStatus::Reviewable label