qt: remove the overzealous assert in `ModelRecoveryAgent` destructor
If the user resets the preferences, closing the application appears to lead to assertion failure.
This should not be a concern, because assertions should not be made in release builds and the if statement afterward already covers the invariant.
Request review @chub.
Merge request reports
Activity
Filter activity
changed milestone to %4.0
added Component::Interface: Qt label
added MRStatus::Reviewable label
added MRStatus::Acceptable label and removed MRStatus::Reviewable label
added MRStatus::Accepted label and removed MRStatus::Acceptable label
MR Acceptance result
This MergeRequest has been Accepted! Congratulations.MR acceptance checks details:
-
MR should be considered mergeable by Gitlab -
Last pipeline should be successful -
MergeRequest should have at least one external review and/or vote -
All threads should be resolved, have votes and score > 0 -
MergeRequest should have no activity (threads/votes) for (72h/72h)
-
added 185 commits
-
7b113763...abd96b82 - 184 commits from branch
videolan:master
- 6fed97a3 - qt: remove the overzealous assert in `ModelRecoveryAgent` destructor
-
7b113763...abd96b82 - 184 commits from branch
enabled an automatic merge when all merge checks for 6fed97a3 pass
Please register or sign in to reply