Skip to content
Snippets Groups Projects

qt: fix pip player can not be dragged if it overlaps flickable view delegate

Merged Fatih Uzunoğlu requested to merge fuzun/vlc:qt/fixpipplayerdragging into master
All threads resolved!

I have observed this bug on both Qt 6.2 and 6.8. Flickable somehow steals the drag if PIP player overlaps with the view's delegate. To reproduce it, try to scroll the view to the middle/center first before dragging the pip player.

I think this is a Qt bug. But we can fix it like this, too.

I have used the old commits from !4357 (merged) (https://code.videolan.org/videolan/vlc/-/merge_requests/4357?commit_id=04295b94ef752a0663144009dd7862d37108cd7e&diff_id=748643#note_442982) that we decided to not use due to increased complexity (they were used to disable flicking with non-touch devices).

This also prevents flicking with non-touch devices.

I have tested on both Qt 6.2 and Qt 6.8.

Request review @chub.

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Fatih Uzunoğlu resolved all threads

    resolved all threads

  • Fatih Uzunoğlu approved this merge request

    approved this merge request

  • MR Acceptance result

    :tada: This MergeRequest has been Accepted! Congratulations.

    MR acceptance checks details:

    • :white_check_mark: MR should be considered mergeable by Gitlab
    • :white_check_mark: Last pipeline should be successful
    • :white_check_mark: MergeRequest should have at least one external review and/or vote
    • :white_check_mark: All threads should be resolved, have votes and score > 0
    • :white_check_mark: MergeRequest should have no activity (threads/votes) for (72h/72h)

    This message was automatically generated by homer-bot.

  • Steve Lhomme added 156 commits

    added 156 commits

    • a7d9ce25...fbe1b1e8 - 152 commits from branch videolan:master
    • b2dbe8d3 - qt: introduce `MainCtx::setFiltersChildMouseEvents()`
    • e87cc1cd - qml: make pip player hover handler blocking
    • 2e4df9db - qml: disable filtering child mouse events in `ListViewExt.qml`
    • 9b86a3b4 - qml: disable filtering child mouse events in `ExpandGridView` flickable

    Compare with previous version

  • Steve Lhomme enabled an automatic merge when all merge checks for 9b86a3b4 pass

    enabled an automatic merge when all merge checks for 9b86a3b4 pass

  • merged

  • Fatih Uzunoğlu mentioned in merge request !6799 (merged)

    mentioned in merge request !6799 (merged)

  • Please register or sign in to reply
    Loading