qml: use focus scope to encapsulate the media library and playlist list views
All threads resolved!
Currently if the user goes up or down from the playlist view, going back ends up with the media library view getting the focus. I think it is better to focus to the last focused view.
Request review @chub.
Merge request reports
Activity
Filter activity
added MRStatus::Reviewable label
changed milestone to %4.0
added Component::Interface: Qt label
- Resolved by Fatih Uzunoğlu
following scenario is broken
- get focus on the playlist
- navigate up to the navigation bar
- close the playlist from there
- navigate down
- focus is lost
added 1 commit
- 48d1f771 - qml: use focus scope to encapsulate the media library and playlist list views
added MRStatus::InReview label and removed MRStatus::Reviewable label
added MRStatus::Acceptable label and removed MRStatus::InReview label
added MRStatus::Accepted label and removed MRStatus::Acceptable label
MR Acceptance result
This MergeRequest has been Accepted! Congratulations.MR acceptance checks details:
-
MR should be considered mergeable by Gitlab -
Last pipeline should be successful -
MergeRequest should have at least one external review and/or vote -
All threads should be resolved, have votes and score > 0 -
MergeRequest should have no activity (threads/votes) for (72h/72h)
-
added 219 commits
-
48d1f771...6151e45a - 218 commits from branch
videolan:master
- 5db139a9 - qml: use focus scope to encapsulate the media library and playlist list views
-
48d1f771...6151e45a - 218 commits from branch
enabled an automatic merge when all merge checks for 5db139a9 pass
Please register or sign in to reply