macosx: Main menu improvements and fixes
Fixes bugs with the enablement state of certain menu items and unifies/simplifies the code around this by focusing on the use ad implementation of NSUserInterfaceValidation protocol
Signed-off-by: Claudio Cambra developer@claudiocambra.com
Merge request reports
Activity
changed milestone to %4.0
added Component::Interface: macOS Platform::macOS labels
assigned to @claucambra
added MRStatus::Reviewable label
added MRStatus::Accepted label and removed MRStatus::Reviewable label
MR Acceptance result
This MergeRequest has been Accepted! Congratulations.MR acceptance checks details:
-
MR should be considered mergeable by Gitlab -
Last pipeline should be successful -
No activity on MR (no thread, no vote) and last update is long enough
-
- Resolved by Claudio Cambra
added MRStatus::InReview label and removed MRStatus::Accepted label
added MRStatus::Acceptable label and removed MRStatus::InReview label
added MRStatus::Accepted label and removed MRStatus::Acceptable label
MR Acceptance result
This MergeRequest has been Accepted! Congratulations.MR acceptance checks details:
-
MR should be considered mergeable by Gitlab -
Last pipeline should be successful -
MergeRequest should have at least one external review and/or vote -
All threads should be resolved, and score >= 0 -
MergeRequest should have no activity (threads/votes) for (24h/24h)
-
added 354 commits
-
e2433ff0...3221c89f - 317 commits from branch
videolan:master
- 3221c89f...03e19384 - 27 earlier commits
- ce40079d - macosx: Handle visual and channels menu items in validation
- 8b24f132 - macosx: Handle video related item enablement in validate method
- 0e249f6e - macosx: Defer further playback and video and audio menu items enablement to validation
- 3e0ca04a - macosx: Handle vout audio, video, and subtitle tracks enablement in validation
- 1ebfe5d1 - macosx: Clean up track handling in main menu
- ceb4ce96 - macosx: Manually update custom subtitle menu item elements
- caa677c9 - macosx: Remove listening to certain notifications with non-existent selector handlers in mainmenu
- 9dd5c33d - macosx: Update rate controls on capabilities change
- e8d7961d - macosx: Move subtitle entries update handling into track handling menus
- be336c08 - macosx: Handle video-related entries together in validation
Toggle commit list-
e2433ff0...3221c89f - 317 commits from branch
enabled an automatic merge when all merge checks for be336c08 pass