Skip to content
Snippets Groups Projects

macosx: Main menu improvements and fixes

Merged Claudio Cambra requested to merge claucambra/vlc:work/playback-menu-fixes into master
All threads resolved!

Fixes bugs with the enablement state of certain menu items and unifies/simplifies the code around this by focusing on the use ad implementation of NSUserInterfaceValidation protocol

Signed-off-by: Claudio Cambra developer@claudiocambra.com

Merge request reports

Merge request pipeline #556472 passed

Merge request pipeline passed for be336c08

Test coverage 17.99% (0.24%) from 1 job
Approval is optional

Merged by Steve LhommeSteve Lhomme 4 months ago (Jan 18, 2025 9:27am UTC)

Merge details

  • Changes merged into master with be336c08.
  • Deleted the source branch.
  • Auto-merge enabled

Pipeline #556478 passed

Pipeline passed for be336c08 on master

Test coverage 17.72% (0.24%) from 1 job

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Claudio Cambra resolved all threads

    resolved all threads

  • MR Acceptance result

    :tada: This MergeRequest has been Accepted! Congratulations.

    MR acceptance checks details:

    • :white_check_mark: MR should be considered mergeable by Gitlab
    • :white_check_mark: Last pipeline should be successful
    • :white_check_mark: MergeRequest should have at least one external review and/or vote
    • :white_check_mark: All threads should be resolved, and score >= 0
    • :white_check_mark: MergeRequest should have no activity (threads/votes) for (24h/24h)

    This message was automatically generated by homer-bot.

  • Steve Lhomme added 354 commits

    added 354 commits

    • e2433ff0...3221c89f - 317 commits from branch videolan:master
    • 3221c89f...03e19384 - 27 earlier commits
    • ce40079d - macosx: Handle visual and channels menu items in validation
    • 8b24f132 - macosx: Handle video related item enablement in validate method
    • 0e249f6e - macosx: Defer further playback and video and audio menu items enablement to validation
    • 3e0ca04a - macosx: Handle vout audio, video, and subtitle tracks enablement in validation
    • 1ebfe5d1 - macosx: Clean up track handling in main menu
    • ceb4ce96 - macosx: Manually update custom subtitle menu item elements
    • caa677c9 - macosx: Remove listening to certain notifications with non-existent selector handlers in mainmenu
    • 9dd5c33d - macosx: Update rate controls on capabilities change
    • e8d7961d - macosx: Move subtitle entries update handling into track handling menus
    • be336c08 - macosx: Handle video-related entries together in validation

    Compare with previous version

  • Steve Lhomme enabled an automatic merge when all merge checks for be336c08 pass

    enabled an automatic merge when all merge checks for be336c08 pass

  • merged

  • Please register or sign in to reply
    Loading