qt: terminate the application on scene graph error in CompositorDirectComposition

When scene graph encounters an error, we are already past the latest stage where recovery is possible. The interface remains nonfunctional in this case, thus the application must be terminated. This is already done by Qt itself when the signal is not connected, but in this case we connect to the signal to let the waiting video thread continue and to print the error.

Note that "If a signal is connected to several slots, the slots are activated in the same order in which the connections were made". So, in this case exit is going to be called after the error is printed, which is the intended behavior.

Since !6013 was not merged, we need to do this otherwise the application may end up with broken interface.

Request review @chub.

An alternative to this would be removing the already existing connection and let Qt terminate the application itself. Due to abort(), it is not too relevant if the video thread is waiting an answer or not, as the whole application terminates anyway.

added MRStatus::Reviewable label

changed milestone to %4.0

added Component::Interface: Qt label

approved this merge request

added MRStatus::Acceptable label and removed MRStatus::Reviewable label

added MRStatus::Accepted label and removed MRStatus::Acceptable label

MR Acceptance result

This MergeRequest has been Accepted! Congratulations.

MR acceptance checks details:

• MR should be considered mergeable by Gitlab
• Last pipeline should be successful
• MergeRequest should have at least one external review and/or vote
• All threads should be resolved, have votes and score > 0
• MergeRequest should have no activity (threads/votes) for (72h/72h)

This message was automatically generated by homer-bot.

added 142 commits

• 4b20fc82...7c9fef82 - 141 commits from branch videolan:master
• b01a8797 - qt: terminate the application on scene graph error in CompositorDirectComposition

Compare with previous version

enabled an automatic merge when all merge checks for b01a8797 pass

merged