Skip to content
Snippets Groups Projects

qt: allow seek bar tool tip to go beyond the boundaries of interface window with Qt 6.8

Merged Fatih Uzunoğlu requested to merge fuzun/vlc:qt/tooltippopuptype into master

Qt 6.8 brings this possibility, but I'm not sure if we should unconditionally do it. Showing and hiding a window is more expensive than showing an item in the scene graph, and I'm not convinced about the fading animation that some platforms apply when it is in a separate window. The main advantage of this is to be able to go beyond the interface boundaries, like VLC 3.

Alternative is adding an option for it.

Opinion @chub?

Merge request reports

Merge request pipeline #535525 passed

Merge request pipeline passed for a374c46d

Test coverage 17.61% (0.01%) from 1 job
Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Fatih Uzunoğlu added 242 commits

    added 242 commits

    • ed047dba...3416bca8 - 239 commits from branch videolan:master
    • 61bfe5a5 - qml: calculate height properly in PointingTooltip
    • 53e170e2 - qml: do not offset the arrow in PointingTooltip when not necessary
    • 1d261981 - qml: use window popup for ToolTipExt with Qt 6.8

    Compare with previous version

  • Fatih Uzunoğlu resolved all threads

    resolved all threads

  • Pierre Lamot approved this merge request

    approved this merge request

  • MR Acceptance result

    :tada: This MergeRequest has been Accepted! Congratulations.

    MR acceptance checks details:

    • :white_check_mark: MR should be considered mergeable by Gitlab
    • :white_check_mark: Last pipeline should be successful
    • :white_check_mark: MergeRequest should have at least one external review and/or vote
    • :white_check_mark: All threads should be resolved, have votes and score > 0
    • :white_check_mark: MergeRequest should have no activity (threads/votes) for (72h/72h)

    This message was automatically generated by homer-bot.

  • Steve Lhomme added 153 commits

    added 153 commits

    • 1d261981...d689072f - 150 commits from branch videolan:master
    • 554ab5d4 - qml: calculate height properly in PointingTooltip
    • d17f5380 - qml: do not offset the arrow in PointingTooltip when not necessary
    • a374c46d - qml: use window popup for ToolTipExt with Qt 6.8

    Compare with previous version

  • Steve Lhomme enabled an automatic merge when all merge checks for a374c46d pass

    enabled an automatic merge when all merge checks for a374c46d pass

  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading