video_output/apple: Fix rotation api availability checks

Signed-off-by: Claudio Cambra developer@claudiocambra.com

changed milestone to %4.0

added Component::Video: macOS / iOS / tvOS / visionOS Platform::macOS labels

assigned to @claucambra

Checking for max allowed is the right thing to do, as it indicates the SDK we build against, which is what we care about for these being available at build time.

Besides, this MR just makes these checks never pass as the right name would be *_VERSION_MIN_REQUIRED.

Please post the build errors you get and the SDK you are using (xcrun --show-sdk-version and xcrun --show-sdk-path)

requested review from @umxprime

added 1 commit

• d702eddb - video_output/apple: Fix rotation api availability checks by also checking for min required

Compare with previous version

added MRStatus::WaitingForReviewerFeedback label

added 1 commit

• 671867d3 - video_output/apple: Fix rotation api availability check by using API_AVAILABLE

Compare with previous version

changed the description

added MRStatus::NotCompliant label and removed MRStatus::WaitingForReviewerFeedback label

added 1 commit

• 72042c6d - video_output/apple: Fix rotation api availability check by using API_AVAILABLE

Compare with previous version

resolved all threads

approved this merge request

Looking at CI there seem to be issues left:

/Volumes/External/videolanci/builds/vCi6yJP3/0/claucambra/vlc/extras/package/macosx/../../../modules/video_output/apple/VLCSampleBufferDisplay.m:140:5: warning: 'TARGET_OS_VISION' is not defined, evaluates to 0 [-Wundef-prefix=TARGET_OS_]
#if TARGET_OS_VISION
    ^
/Volumes/External/videolanci/builds/vCi6yJP3/0/claucambra/vlc/extras/package/macosx/../../../modules/video_output/apple/VLCSampleBufferDisplay.m:164:6: warning: 'TARGET_OS_VISION' is not defined, evaluates to 0 [-Wundef-prefix=TARGET_OS_]
#if !TARGET_OS_VISION
     ^
  CCLD     libheadphone_channel_mixer_plugin.la
  CCLD     libmono_plugin.la
  CCLD     libremap_plugin.la
  CCLD     libsimple_channel_mixer_plugin.la
  CCLD     libtrivial_channel_mixer_plugin.la
/Volumes/External/videolanci/builds/vCi6yJP3/0/claucambra/vlc/extras/package/macosx/../../../modules/video_output/apple/VLCSampleBufferDisplay.m:672:29: error: unknown receiver 'VLCPixelBufferRotationContextVT'; did you mean 'VLCPixelBufferRotationContextCI'?
        _rotationContext = [VLCPixelBufferRotationContextVT new];
                            ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
                            VLCPixelBufferRotationContextCI
/Volumes/External/videolanci/builds/vCi6yJP3/0/claucambra/vlc/extras/package/macosx/../../../modules/video_output/apple/VLCSampleBufferDisplay.m:301:12: note: 'VLCPixelBufferRotationContextCI' declared here
@interface VLCPixelBufferRotationContextCI : NSObject <VLCPixelBufferRotationContext>
           ^
  CXXLD    libspatialaudio_plugin.la
2 warnings and 1 error generated.
  CCLD     libtospdif_plugin.la

added 1 commit

• 899fc2dc - video_output/apple: Check if TARGET_OS_VISION is defined before checking its state

Compare with previous version

added 1 commit

• e4fa0abd - video_output/apple: Fix unknown receiver 'VLCPixelBufferRotationContextVT'

Compare with previous version

added 4 commits

• b6940087 - 1 commit from branch videolan:master
• a5c099e7 - video_output/apple: Fix rotation api availability check by using API_AVAILABLE
• f2bb31c3 - video_output/apple: Check if TARGET_OS_VISION is defined before checking its state
• 301f7b4f - video_output/apple: Fix unknown receiver 'VLCPixelBufferRotationContextVT'

Compare with previous version

added MRStatus::WaitingForReviewerFeedback label and removed MRStatus::NotCompliant label

resolved all threads

approved this merge request

added MRStatus::Acceptable label and removed MRStatus::WaitingForReviewerFeedback label

added MRStatus::Accepted label and removed MRStatus::Acceptable label

MR Acceptance result

This MergeRequest has been Accepted! Congratulations.

MR acceptance checks details:

• MR should be considered mergeable by Gitlab
• Last pipeline should be successful
• MergeRequest should have at least one external review and/or vote
• All threads should be resolved, and score >= 0
• MergeRequest should have no activity (threads/votes) for (24h/24h)

This message was automatically generated by homer-bot.

added 26 commits

• 301f7b4f...b798bfa6 - 23 commits from branch videolan:master
• 03743b57 - video_output/apple: Fix rotation api availability check by using API_AVAILABLE
• 6729b389 - video_output/apple: Check if TARGET_OS_VISION is defined before checking its state
• 7341cf31 - video_output/apple: Fix unknown receiver 'VLCPixelBufferRotationContextVT'

Compare with previous version

enabled an automatic merge when the pipeline for 7341cf31 succeeds

merged