qml: make playlist listview's background opaque in small screen mode

Playqueue pane's background uses a hack to block what is shown beneath but instead makes window background to pass through. This hack is used because play queue is hierarchically placed in a position where there is background that is not fully transparent.

This conflicts with the "small screen" view, since the stack view does not get unusably small but rather blows up into the area used by the play queue. This constitutes a problem, because play queue effectively prevents rendering the part of the stack view that overlaps with its size.

Request review @chub.

Play queue's opaque background comes from its parent, which is a Rectangle with color theme.bg.primary. One alternative might be to make it transparent, and use frosted glass effect for the stack view content. This might require moving the play queue to a new hierarchical position, where we might not be able to use anchors anymore.

One may ask: Why currently play queue's parent is an opaque rectangle if play queue is meant to be transparent? That is done because the same parent acts as a background for the mini player, and mini player extends to the play queue (width-wise). We want to have consistent effect for the mini player background.

added MRStatus::InReview label

the playqueue not taking the whole width was intentional

added 1 commit

• 652d8f94 - qml: make playlist listview's background opaque in small screen mode

Compare with previous version

changed title from qml: do not show stack view beneath the play queue in "small screen" mode to qml: make playlist listview's background opaque in small screen mode

changed milestone to %4.0

added Component::Interface: Qt label

approved this merge request

resolved all threads

added MRStatus::Acceptable label and removed MRStatus::InReview label

added MRStatus::Accepted label and removed MRStatus::Acceptable label

MR Acceptance result

This MergeRequest has been Accepted! Congratulations.

MR acceptance checks details:

• MR should be considered mergeable by Gitlab
• Last pipeline should be successful
• MergeRequest should have at least one external review and/or vote
• All threads should be resolved, have votes and score > 0
• MergeRequest should have no activity (threads/votes) for (72h/72h)

This message was automatically generated by homer-bot.

added 159 commits

• 652d8f94...9d84c7fa - 158 commits from branch videolan:master
• 694d51a7 - qml: make playlist listview's background opaque in small screen mode

Compare with previous version

enabled an automatic merge when the pipeline for 694d51a7 succeeds

merged