Skip to content
Snippets Groups Projects

qt: Add Dark Mode [Closed due to incorrect rebase] Reopened in !6131

Closed Pratik Patel requested to merge (removed):darkmode into 3.0.x

Reopened in !6131 (merged)

Added Native Dark Mode For VLC 3.0

  • Added checkbox in Preferences to switch to dark mode. (sprefs-interface.ui)
  • Added a new function for Windows so a dark title-bar is enabled when using dark mode in qvlcframe.hpp.
  • Modified about.ui file and removed custom stylesheet. Now the stylesheet is applied in the constructor of the About Dialog based on the mode (help.cpp).
  • Dark mode works best with fusion. It is applied dynamically but requires restart to work properly.

DARK TITLEBAR FOR WINDOWS

  • This is implemented in the files qvlcframe.hpp.
  • It uses DwmSetWindowAttribute Function to from the dwmapi.dll to apply dark titlebar.
  • Requires Restart.

Enabled the StyleComboBox For Windows:

  • Fusion
  • Windows
  • WindowsXP
  • WindowsVista

PREVIEWS:

image.png

Screenshot_2024-08-24_192713

Edited by Pratik Patel

Merge request reports

Checking pipeline status.

Approval is optional

Closed by Pratik PatelPratik Patel 6 months ago (Oct 4, 2024 1:08pm UTC)

Merge details

  • The changes were not merged into master.

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Pratik Patel added 2 commits

    added 2 commits

    • 6509a49f - Isolate windows specific code
    • fb20625a - Isolate windows specific code

    Compare with previous version

  • Pratik Patel added 1 commit

    added 1 commit

    Compare with previous version

  • Pierre Lamot
  • Pierre Lamot
  • Pierre Lamot
  • Pierre Lamot
  • Pierre Lamot
  • Pratik Patel added 1 commit

    added 1 commit

    • fcc4b787 - Compile windows-specific file on windows only

    Compare with previous version

  • Pratik Patel added 1 commit

    added 1 commit

    • 2c06f765 - Optimized code and use boolean instead of QtStyle

    Compare with previous version

  • Pratik Patel added 1 commit

    added 1 commit

    Compare with previous version

  • Pratik Patel added 1 commit

    added 1 commit

    Compare with previous version

  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading