qt: servicesdiscoverymodel: add missing override (!5834) · Merge requests · VideoLAN / VLC

Alexandre Janniaux requested to merge alexandre-janniaux/vlc:qt-sd-override-warning/1 into master Aug 04, 2024

Commit 2212ef87 added getSortFunction as a virtual pure function, but the class was not updated to override it.

Fixes the following warning:

../modules/gui/qt/network/servicesdiscoverymodel.cpp:141:50: warning: 'getSortFunction' overrides a member function but is not marked 'override' [-Winconsistent-missing-override]
  141 |     LocalListCacheLoader<SDItemPtr>::ItemCompare getSortFunction() const
      |                                                  ^
../modules/gui/qt/util/locallistbasemodel.hpp:39:59: note: overridden virtual function is here
   39 |     virtual typename LocalListCacheLoader<T>::ItemCompare getSortFunction() const = 0;
      |                                                           ^

qt: servicesdiscoverymodel: add missing override

Merge request reports