VLCMediaSource: check file:// for file browsing
An INPUT_TYPE_DIRECTORY might not match with an MRL supported by the CoreFoundation API. The code handling the file browsing is made for local file browsing at locations that are not exposed by services discovery.
Ensure file:// is the scheme used for the MRL to trigger this browsing code. This is not 100% compliant since it doesn't account for a demux but there's probably no reason to have a demux there, and no occurrence to that day.
This avoid bypassing the vlc_media_source/media_tree preparsing when the source has been reported as INPUT_TYPE_DIRECTORY.
Merge request reports
Activity
changed milestone to %4.0
added Component::Interface: macOS Platform::macOS Type::bug labels
added MRStatus::Reviewable label
Uh, can't
file
URIs also be handled by disk demuxers?Yes, but the interfaces (at least macos) currently have custom code for file browsing since file locations are not exposed by SD. Anyway this mainly removes usage of this custom code in situation where it actually breaks the browsing.
added MRStatus::Accepted label and removed MRStatus::Reviewable label
MR Acceptance result
This MergeRequest has been Accepted! Congratulations.MR acceptance checks details:
-
MR should be considered mergeable by Gitlab -
Last pipeline should be successful -
MergeRequest should have at least one external review and/or vote -
All threads should be resolved, and score >= 0 -
MergeRequest should have no activity (threads/votes) for (24h/24h)
-
added 57 commits
-
8dc2a3a9...9f2c91e9 - 55 commits from branch
videolan:master
- b3c18144 - VLCMediaSource: fix typo
- d5de42f4 - VLCMediaSource: check file:// for file browsing
-
8dc2a3a9...9f2c91e9 - 55 commits from branch
enabled an automatic merge when the pipeline for d5de42f4 succeeds