Skip to content
Snippets Groups Projects

contrib: bluray: build for more recent JDK

Open Steve Lhomme requested to merge robUx4/vlc:bluray134 into master
2 unresolved threads

OpenJDK 8 support will drop during the lifetime of VLC 4. We should switch to a newer version.

Also bump the minimum version of libbluray so we don't need to rely on a hack. Even Debian buster has libbluray 1.1.0 and Ubuntu focal has 1.2.0.

And use the latest libbluray version (1.3.4).

Edited by Steve Lhomme

Merge request reports

Members who can merge are allowed to add commits.

Merge request pipeline #479302 passed with warnings

Merge request pipeline passed with warnings for 458c9a40

Test coverage 18.39% (0.05%) from 1 job
Approval is optional
Merge blocked: 3 checks failed

Merge details

  • The source branch is 3827 commits behind the target branch.
  • 1 commit will be added to master.
  • Source branch will be deleted.

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
48 49
49 50 bluray: libbluray-$(BLURAY_VERSION).tar.bz2 .sum-bluray
50 51 $(UNPACK)
52 # use JDK9+ with java 1.7, otherwise JDK11 gives this error:
53 # Source option 6 is no longer supported. Use 7 or later.
54 # we still get this warning:
55 # source value 7 is obsolete and will be removed in a future release
56 sed -i.orig -e 's,=1.6,=1.8,g' $(UNPACK_DIR)/Makefile.am
  • Steve Lhomme mentioned in merge request !5533 (merged)

    mentioned in merge request !5533 (merged)

  • Steve Lhomme added 501 commits

    added 501 commits

    Compare with previous version

  • Steve Lhomme mentioned in merge request !5616 (merged)

    mentioned in merge request !5616 (merged)

  • Steve Lhomme changed the description

    changed the description

    • So using this MR lets the configuration step succeed with the latest JDK, however the java compilation itself fails so we need to update the code I'm afraid:

      /BDFramePeer.java:31: error: BDFramePeer is not abstract and does not override abstract method getAppropriateGraphicsConfiguration(GraphicsConfiguration) in WindowPeer
    • Author Developer

      Which JDK did you use ?

    • This is with

      java 22.0.1 2024-04-16
      Java(TM) SE Runtime Environment (build 22.0.1+8-16)
      Java HotSpot(TM) 64-Bit Server VM (build 22.0.1+8-16, mixed mode, sharing)
    • Author Developer

      For reference, it works with the JDK 17.

    • Please register or sign in to reply
  • Steve Lhomme mentioned in merge request !6140

    mentioned in merge request !6140

  • Please register or sign in to reply
    Loading