Skip to content
Snippets Groups Projects

qt: refactoring and code cleanup in browse model and view

Merged Prince Gupta requested to merge jagannatharjun/vlc:browseview-refactoring into master
All threads resolved!

extracted from !5168 (closed)

Merge request reports

Merge request pipeline #468541 passed with warnings

Merge request pipeline passed with warnings for 4fc045f1

Test coverage 18.33% (0.00%) from 1 job

Merged by Jean-Baptiste KempfJean-Baptiste Kempf 11 months ago (May 10, 2024 4:19pm UTC)

Loading

Pipeline #468704 passed with warnings

Pipeline passed with warnings for 4fc045f1 on master

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Pierre Lamot
  • Prince Gupta added 1 commit

    added 1 commit

    • 06d74897 - qml: fix focus handling in BrowseTreeHeader

    Compare with previous version

  • Prince Gupta added 2 commits

    added 2 commits

    • 877f4f97 - qml: separate loading and empty component in BrowseTreeDisplay
    • e29044a1 - qml: fix focus handling in BrowseTreeHeader

    Compare with previous version

  • Prince Gupta added 2 commits

    added 2 commits

    • bd651cf1 - qml: fix focus handling in BrowseTreeHeader
    • e94957ba - qml: fix double padding

    Compare with previous version

  • Prince Gupta resolved all threads

    resolved all threads

  • Pierre Lamot approved this merge request

    approved this merge request

  • MR Acceptance result

    :tada: This MergeRequest has been Accepted! Congratulations.

    MR acceptance checks details:

    • :white_check_mark: MR should be considered mergeable by Gitlab
    • :white_check_mark: Last pipeline should be successful
    • :white_check_mark: MergeRequest should have at least one external review and/or vote
    • :white_check_mark: All threads should be resolved, have votes and score > 0
    • :white_check_mark: MergeRequest should have no activity (threads/votes) for (72h/72h)

    This message was automatically generated by homer-bot.

  • added 139 commits

    • e94957ba...24e663be - 132 commits from branch videolan:master
    • 870911a6 - qml: refactor loading view in MainViewLoader for clarity
    • ac3b1833 - qml: add more strict constaints for 'loadingComponent'
    • 0d955392 - qml: remove redundant property
    • 146575c0 - qt: remove shadowed member function
    • 0c96e3b6 - qml: separate loading and empty component in BrowseTreeDisplay
    • 4149672b - qml: fix focus handling in BrowseTreeHeader
    • 4fc045f1 - qml: fix double padding

    Compare with previous version

  • Jean-Baptiste Kempf enabled an automatic merge when the pipeline for 4fc045f1 succeeds

    enabled an automatic merge when the pipeline for 4fc045f1 succeeds

  • Please register or sign in to reply
    Loading