test: input_decoder: check 708 CCs

Only the last 4 commits should be reviewed.

changed milestone to %4.0

added Component::Core: Input label

changed the description

requested review from @fcartegnie

Depends on !4358 (merged)

added 5 commits

• ddc08d10 - test: input_decoder: check 4 CEA608 tracks can be added
• 02bea971 - es_out: add es_out_SetClosedCaptionsDecoder
• fc9dc38d - input: add INPUT_CONTROL_SET_CLOSED_CAPTIONS_DECODER
• d0f6d472 - player: add vlc_player_SetClosedCaptionsDecoder
• a4d2147c - test: input_decoder: check that 64 CEA708 tracks can be added

Compare with previous version

Can you describe the use case in the commit, at least for ES_OUT_PRIV_SET_CLOSED_CAPTIONS_DECODER ?

added MRStatus::WaitingForReviewerFeedback label

added 15 commits

• a4d2147c...d777a335 - 5 earlier commits
• 0d9f49c1 - test: input_decoder: fill the cc frame with valid data
• 8eb8cae0 - test: input_decoder: use a valid i_reorder_depth
• 91705a5a - test: input_decoder: add a new scenario for pkt CC rendering
• bef90443 - test: input_decoder: split decoder_decode_check_cc
• fb262a22 - test: input_decoder: add a new scenario for dec CC rendering
• 8faf1373 - test: input_decoder: check that 4 CEA608 tracks can be added
• 2413b90f - es_out: add es_out_SetClosedCaptionsDecoder
• 67b07246 - input: add INPUT_CONTROL_SET_CLOSED_CAPTIONS_DECODER
• ec18d4cd - player: add vlc_player_SetClosedCaptionsDecoder
• 89db1a14 - test: input_decoder: check that 64 CEA708 tracks can be added

Compare with previous version

added 72 commits

• 89db1a14...e380c2a8 - 53 commits from branch videolan:master
• e380c2a8...1470572a - 9 earlier commits
• 15fb047b - test: input_decoder: fill the cc frame with valid data
• ba8fe128 - test: input_decoder: use a valid i_reorder_depth
• 9d6448c1 - test: input_decoder: add a new scenario for pkt CC rendering
• 13a97643 - test: input_decoder: split decoder_decode_check_cc
• 7d984009 - test: input_decoder: add a new scenario for dec CC rendering
• eebcb982 - test: input_decoder: check that 4 CEA608 tracks can be added
• 2b49d06d - es_out: add es_out_SetClosedCaptionsDecoder
• dd467387 - input: add INPUT_CONTROL_SET_CLOSED_CAPTIONS_DECODER
• 41f510b8 - player: add vlc_player_SetClosedCaptionsDecoder
• 1fb49085 - test: input_decoder: check that 64 CEA708 tracks can be added

Compare with previous version

added 2 commits

• 5bf89927 - test: input_decoder: split cc_decoder_decode
• 4b0db98d - test: input_decoder: check that CEA708 62 and 63 tracks can be rendered

Compare with previous version

added 6 commits

• 93450b5e - es_out: add es_out_SetClosedCaptionsDecoder
• 15d6f4d4 - input: add input_SetClosedCaptionsDecoder()
• 9c29a087 - player: add vlc_player_SetClosedCaptionsDecoder
• 0c5f785a - test: input_decoder: check that 64 CEA708 tracks can be added
• c253ae4b - test: input_decoder: split cc_decoder_decode
• dfcc1eed - test: input_decoder: check that CEA708 62 and 63 tracks can be rendered

Compare with previous version

Removed the API ability to change the CC decoder midstream. It is possible, but it adds extra complexity when handling es_out.c ES removal.

requested review from @alexandre-janniaux and removed review request for @fcartegnie

added MRStatus::InReview label and removed MRStatus::WaitingForReviewerFeedback label

TBH, that API seems very impractical. LibVLC app developers should not have to know what that parameter even means (and most of them indeed don't).

LibVLC is supposed to work out of the box with default settings. But if the default setting works, why do we even need this function?

added 19 commits

• dfcc1eed...bd02a17e - 9 earlier commits
• 410be6aa - test: input_decoder: check that CC frames from pkt can be rendered
• 59dc29bd - test: input_decoder: split decoder_decode_check_cc
• c38af7d0 - test: input_decoder: check that CC frames from dec can be rendered
• dfb6f9bb - test: input_decoder: check that 4 CEA608 tracks can be added
• 19acb94c - es_out: add es_out_SetClosedCaptionsDecoder
• 65f67746 - input: add input_SetClosedCaptionsDecoder()
• dfcf8be8 - player: add vlc_player_SetClosedCaptionsDecoder
• 8e3084cb - test: input_decoder: check that 64 CEA708 tracks can be added
• 6d79242b - test: input_decoder: split cc_decoder_decode
• 5a319bbe - test: input_decoder: check that CEA708 62 and 63 tracks can be rendered

Compare with previous version

added 11 commits

• 87f8c135 - 1 earlier commit
• d962ff14 - test: input_decoder: check that CC frames from pkt can be rendered
• 2c8545a1 - test: input_decoder: split decoder_decode_check_cc
• 36778e20 - test: input_decoder: check that CC frames from dec can be rendered
• ff2d33c0 - test: input_decoder: check that 4 CEA608 tracks can be added
• 1c20f987 - test: input_decoder: print the name of the running scenario
• 2a40ddfc - test: input_decoder: remove unused sem
• 136362d6 - test: input_decoder: replace sout with item_option
• 4e959ec9 - test: input_decoder: check that 64 CEA708 tracks can be added
• eb66c386 - test: input_decoder: split cc_decoder_decode
• b88a553b - test: input_decoder: check that CEA708 62 and 63 tracks can be rendered

Compare with previous version

changed title from player: add vlc_player_SetClosedCaptionsDecoder() and tests to test: input_decoder: check 708 CCs

added 1 commit

• e9b21cad - test: input_decoder: check that CEA708 10 and 63 tracks can be rendered

Compare with previous version