Skip to content
Snippets Groups Projects

contrib/libaribcaption: Update library version and improve performance

Merged xqq requested to merge xqq/vlc:libaribcaption into master

Hi, I'm the author and maintainer of the libaribcaption project and codec/arib/libaribcaption.c module.

Since I have released several versions for libaribcaption, it's time to download the tarball file of a specific version, rather than pulling the entire git repository. I changed the rules.mak to download libaribcaption-1.1.1.tar.gz from github.

In addition, I added some logic to detect whether the caption images are changed, and skip the rendering call if unchanged to avoid the overhead of underlying repeated memcpy occurring per frame.

I've tested these changes and it works as expected.

Regards

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Hi,

    This commit title is too long "codec: libaribcaption: Update library version and improve rendering performance". And the commit text should be a sentence, not starting with "codec: ".

  • xqq changed title from codec: libaribcaption: Update library version and improve rendering performance to contrib/libaribcaption: Update library version and improve performance

    changed title from codec: libaribcaption: Update library version and improve rendering performance to contrib/libaribcaption: Update library version and improve performance

  • xqq added 1 commit

    added 1 commit

    • 3979eda2 - codec/libaribcaption: Skip rendering if images not changed for avoiding unnecessary memory copy

    Compare with previous version

  • Author Contributor

    Force-pushed with suggested changes.

  • Very cool.

  • Jean-Baptiste Kempf approved this merge request

    approved this merge request

  • Jean-Baptiste Kempf resolved all threads

    resolved all threads

  • Author Contributor

    Thanks.

  • Jean-Baptiste Kempf resolved all threads

    resolved all threads

  • Thomas Guillem approved this merge request

    approved this merge request

  • Steve Lhomme changed milestone to %4.0

    changed milestone to %4.0

  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading