libvlc/player: Add a new media stopping event
Provides an event to the player user and libvlc application.
The event signals the host application that any resources linked to the input media are not needed anymore and can be dropped.
Superseeds !4125 (closed) !4161 (closed)
Merge request reports
Activity
changed milestone to %4.0
added Component::Bindings: LibVLC (native API) label
- Resolved by Denis Charmet
- Resolved by Denis Charmet
- Resolved by Thomas Guillem
libvlc_MediaPlayerStopping
/libvlc_MediaPlayerMediaStopping
this is kinda confusing... but I don't know what better name to suggest.Side note: Is this a good MR to handle or consider #26819?
- Resolved by Alexandre Janniaux
- Resolved by Alexandre Janniaux
libvlc_MediaPlayerStopping
/libvlc_MediaPlayerMediaStopping
this is kinda confusing... but I don't know what better name to suggest.Yes, I considered the confusion also. In the vlc_player core, that's not a problem because there is the player state (stopping) and the player event (media stopping) but libvlc is mixing both unfortunately. :/ But Thomas's MR should change that.
Side note: Is this a good MR to handle or consider #26819?
I need to check but technically, as long as you don't stop yourself, this event will signal that the end of the media was reached. I guess it does not entirely match what you want, right?
added 56 commits
-
ec9ed160...3962ac19 - 43 commits from branch
videolan:master
- 3962ac19...1eaaf29f - 3 earlier commits
- b2c606af - vlc_player: add a new on_stopping_current_media event
- 60284316 - libvlc_events: add libvlc_MediaPlayerMediaStopping
- b71b5fef - test: player: add player state_to_string function
- a7fbda3f - test: player: dump the state vec when asserting
- e685cd9b - test: player: add a state_equal() function
- 66f74502 - lib: media_player: move vlc_assert_unreachable
- e1a6d191 - lib: media_player: split function
- 273f38d7 - player: signal on_current_media_stopping event
- e77eed9e - lib: media player: signal stopping media event
- d7c60a94 - test: libvlc_callback: check imem-access behaviour
Toggle commit list-
ec9ed160...3962ac19 - 43 commits from branch
added MRStatus::InReview label
added MRStatus::Acceptable label and removed MRStatus::InReview label
added MRStatus::Accepted label and removed MRStatus::Acceptable label
MR Acceptance result
This MergeRequest has been Accepted! Congratulations. MR acceptance checks details:
-
MR should be considered mergeable by Gitlab -
Last pipeline should be successful -
MergeRequest should have at least one external review and/or vote -
All threads should be resolved, and score >= 0 -
MergeRequest should have no activity (threads/votes) for (24h/24h)
-
added 499 commits
-
d7c60a94...764317d4 - 486 commits from branch
videolan:master
- 764317d4...5d502b0b - 3 earlier commits
- 2ae6636c - vlc_player: add a new on_stopping_current_media event
- 4ac61be1 - libvlc_events: add libvlc_MediaPlayerMediaStopping
- 9bb751cb - test: player: add player state_to_string function
- bcba4461 - test: player: dump the state vec when asserting
- 52a231b8 - test: player: add a state_equal() function
- 4a35193e - lib: media_player: move vlc_assert_unreachable
- 6d40b91c - lib: media_player: split function
- e651ac80 - player: signal on_current_media_stopping event
- 3841df7a - lib: media player: signal stopping media event
- 30d1237d - test: libvlc_callback: check imem-access behaviour
Toggle commit list-
d7c60a94...764317d4 - 486 commits from branch
enabled an automatic merge when the pipeline for 30d1237d succeeds