Skip to content
Snippets Groups Projects

libvlc/player: Add a new media stopping event

All threads resolved!

Provides an event to the player user and libvlc application.

The event signals the host application that any resources linked to the input media are not needed anymore and can be dropped.

Superseeds !4125 (closed) !4161 (closed)

Edited by Alexandre Janniaux

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Denis Charmet
  • Since I was the one who suggested that I won't be the one who opposes it :)

  • Thomas Guillem
  • Thomas Guillem approved this merge request

    approved this merge request

  • libvlc_MediaPlayerStopping / libvlc_MediaPlayerMediaStopping this is kinda confusing... but I don't know what better name to suggest.

    Side note: Is this a good MR to handle or consider #26819?

    • Resolved by Alexandre Janniaux

      libvlc_MediaPlayerStopping / libvlc_MediaPlayerMediaStopping this is kinda confusing... but I don't know what better name to suggest.

      Yes, I considered the confusion also. In the vlc_player core, that's not a problem because there is the player state (stopping) and the player event (media stopping) but libvlc is mixing both unfortunately. :/ But Thomas's MR should change that.

      Side note: Is this a good MR to handle or consider #26819?

      I need to check but technically, as long as you don't stop yourself, this event will signal that the end of the media was reached. I guess it does not entirely match what you want, right?

  • Alexandre Janniaux added 56 commits

    added 56 commits

    • ec9ed160...3962ac19 - 43 commits from branch videolan:master
    • 3962ac19...1eaaf29f - 3 earlier commits
    • b2c606af - vlc_player: add a new on_stopping_current_media event
    • 60284316 - libvlc_events: add libvlc_MediaPlayerMediaStopping
    • b71b5fef - test: player: add player state_to_string function
    • a7fbda3f - test: player: dump the state vec when asserting
    • e685cd9b - test: player: add a state_equal() function
    • 66f74502 - lib: media_player: move vlc_assert_unreachable
    • e1a6d191 - lib: media_player: split function
    • 273f38d7 - player: signal on_current_media_stopping event
    • e77eed9e - lib: media player: signal stopping media event
    • d7c60a94 - test: libvlc_callback: check imem-access behaviour

    Compare with previous version

  • Alexandre Janniaux marked this merge request as ready

    marked this merge request as ready

  • Alexandre Janniaux changed title from Draft: add a new media stopping event to libvlc/player: Add a new media stopping event

    changed title from Draft: add a new media stopping event to libvlc/player: Add a new media stopping event

  • Alexandre Janniaux changed the description

    changed the description

  • Alexandre Janniaux resolved all threads

    resolved all threads

  • MR Acceptance result

    :tada: This MergeRequest has been Accepted! Congratulations.

    MR acceptance checks details:

    • :white_check_mark: MR should be considered mergeable by Gitlab
    • :white_check_mark: Last pipeline should be successful
    • :white_check_mark: MergeRequest should have at least one external review and/or vote
    • :white_check_mark: All threads should be resolved, and score >= 0
    • :white_check_mark: MergeRequest should have no activity (threads/votes) for (24h/24h)

    This message was automatically generated by homer-bot.

  • Steve Lhomme added 499 commits

    added 499 commits

    • d7c60a94...764317d4 - 486 commits from branch videolan:master
    • 764317d4...5d502b0b - 3 earlier commits
    • 2ae6636c - vlc_player: add a new on_stopping_current_media event
    • 4ac61be1 - libvlc_events: add libvlc_MediaPlayerMediaStopping
    • 9bb751cb - test: player: add player state_to_string function
    • bcba4461 - test: player: dump the state vec when asserting
    • 52a231b8 - test: player: add a state_equal() function
    • 4a35193e - lib: media_player: move vlc_assert_unreachable
    • 6d40b91c - lib: media_player: split function
    • e651ac80 - player: signal on_current_media_stopping event
    • 3841df7a - lib: media player: signal stopping media event
    • 30d1237d - test: libvlc_callback: check imem-access behaviour

    Compare with previous version

  • Steve Lhomme enabled an automatic merge when the pipeline for 30d1237d succeeds

    enabled an automatic merge when the pipeline for 30d1237d succeeds

  • merged

  • Please register or sign in to reply
    Loading