medialibrary: thumb: check fclose while saving
It should not be assumed that the thumbnail was saved properly when
fclose
fails.
The RAII wrapper here does not improve readability or shorten the code.
This MR supersede !4057 (closed) by working around the warning and handling the error at the same time.
Merge request reports
Activity
added Component::Media Library label
changed milestone to %4.0
- Resolved by Alaric Senat
Thanks! can you add the warning + the __nonnull((1)) explanation from the previous MR so that we keep a trace of it? The warning was pretty confusing :D
added MRStatus::NotCompliant label
added 1 commit
- 910eb391 - medialibrary: thumb: check fclose while saving
added MRStatus::Acceptable label and removed MRStatus::NotCompliant label
added MRStatus::Accepted label and removed MRStatus::Acceptable label
MR Acceptance result
This MergeRequest has been Accepted! Congratulations.MR acceptance checks details:
-
MR should be considered mergeable by Gitlab -
Last pipeline should be successful -
MergeRequest should have at least one external review and/or vote -
All threads should be resolved, and score >= 0 -
MergeRequest should have no activity (threads/votes) for (24h/24h)
-
added 35 commits
-
910eb391...e38b161b - 34 commits from branch
videolan:master
- f1d4ade9 - medialibrary: thumb: check fclose while saving
-
910eb391...e38b161b - 34 commits from branch
You should not rebase will master is going to take 1h to build. This MR is now also going to build all the contribs for 1h in parallel because the contribs from master are not ready. If you waited for 1h it would just take 5 minutes to build. And these 55 minutes of CI can be used for something else.